Improve CI build/test perf #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use SHA-256 for internal proving tests (2x faster than poseidon) * Avoid hanging cargo-risczero tests waiting on stdin * Avoid building `risc0-zkvm` twice with and without the "prove" feature
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SchmErik
reviewed
Nov 7, 2023
| - run: cargo test -p risc0-r0vm -F $FEATURE -F disable-dev-mode | ||
| - run: cargo test -p risc0-zkvm -F $FEATURE -F fault-proof -F prove |
There was a problem hiding this comment.
NICE! I feel like we should have caught something like this during code review. I'll try my best to be aware of something like this in the future
There was a problem hiding this comment.
By "Something like this", I meant this hunk and the previous one
flaub
added a commit
that referenced
this pull request
Nov 8, 2023
* Use SHA-256 for internal proving tests (2x faster than poseidon) * Avoid hanging cargo-risczero tests waiting on stdin * Avoid building `risc0-zkvm` twice with and without the "prove" feature
flaub
added a commit
that referenced
this pull request
Nov 8, 2023
* Use SHA-256 for internal proving tests (2x faster than poseidon) * Avoid hanging cargo-risczero tests waiting on stdin * Avoid building `risc0-zkvm` twice with and without the "prove" feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
risc0-zkvmtwice with and without the "prove" feature