Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: jwt-validator example #1218

Merged
merged 14 commits into from
Dec 21, 2023
Merged

feat: jwt-validator example #1218

merged 14 commits into from
Dec 21, 2023

Conversation

hmrtn
Copy link
Member

@hmrtn hmrtn commented Dec 12, 2023

Adds a JSON Web Token validator to demonstrate validating RS256 signed tokens in the guest.

@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 11:55pm

@hmrtn hmrtn linked an issue Dec 12, 2023 that may be closed by this pull request
Add JWT validation to risc0/examples #1213
Closed
@hmrtn hmrtn force-pushed the hmrtn/jwt-validator-example branch from f4ffeb9 to 2018249 Compare December 12, 2023 03:51
@hmrtn hmrtn force-pushed the hmrtn/jwt-validator-example branch from 19a4558 to f6f8ec4 Compare December 12, 2023 19:39
@hmrtn hmrtn force-pushed the hmrtn/jwt-validator-example branch from f6f8ec4 to 93f2af6 Compare December 12, 2023 19:56
@hmrtn hmrtn marked this pull request as ready for review December 12, 2023 20:17
@hmrtn hmrtn requested a review from flaub December 12, 2023 20:17
@hmrtn hmrtn marked this pull request as draft December 15, 2023 22:57
@hmrtn hmrtn marked this pull request as ready for review December 15, 2023 23:48
@flaub flaub enabled auto-merge (squash) December 20, 2023 05:55
@flaub
Copy link
Member

flaub commented Dec 20, 2023

I think we can land this, but we're missing an end 2 end test to ensure this has CI coverage and allows for regression testing. This is important so that if we make a change to the API, we can ensure that this test will be updated when the tests break.

@flaub
Copy link
Member

flaub commented Dec 21, 2023

I suggest we make main call a function. This exact same function is called by the end 2 end test. See for example: https://github.com/risc0/risc0/blob/main/examples/hello-world/src/lib.rs#L53

@flaub flaub merged commit 9b9d491 into main Dec 21, 2023
22 checks passed
@flaub flaub deleted the hmrtn/jwt-validator-example branch December 21, 2023 00:11
@hmrtn hmrtn mentioned this pull request Jan 17, 2024
Merged
flaub added a commit that referenced this pull request Jan 17, 2024
@hmrtn @flaub
feat: jwt-validator example (#1218)
13c2e1e 
Adds a JSON Web Token validator to demonstrate validating RS256 signed
tokens in the guest.

---------

Co-authored-by: Frank Laub <flaub@risc0.com>
flaub added a commit that referenced this pull request Jan 17, 2024
@hmrtn @flaub
feat: jwt-validator example (#1218)
23a4f0d 
Adds a JSON Web Token validator to demonstrate validating RS256 signed
tokens in the guest.

---------

Co-authored-by: Frank Laub <flaub@risc0.com>
SchmErik added a commit that referenced this pull request Feb 15, 2024
@hmrtn @SchmErik
refactor: jwt validator example (#1337)
cda77ef 
Move jwt validation to main function call for e2e testing. 

In reference to this:
#1218 (comment)

Note: jwt example e2e tests have a large cycle count

---------

Co-authored-by: Erik Kaneda <erik@risczero.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaub flaub flaub approved these changes

@austinabell austinabell austinabell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JWT validation to risc0/examples
3 participants
@hmrtn @flaub @austinabell