Rename get_cycle_count to cycle_count #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
flaub
approved these changes
Dec 20, 2023
flaub
added a commit
that referenced
this pull request
Dec 20, 2023
Rust naming guidelines recommend C-GETTER conventions for "getter function". This PR renames `env::get_cycle_count` to `env::cycle_count` to follow these guidelines https://rust-lang.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter --------- Co-authored-by: Frank Laub <frank@risczero.com>
flaub
added a commit
that referenced
this pull request
Jan 17, 2024
Rust naming guidelines recommend C-GETTER conventions for "getter function". This PR renames `env::get_cycle_count` to `env::cycle_count` to follow these guidelines https://rust-lang.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter --------- Co-authored-by: Frank Laub <frank@risczero.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust naming guidelines recommend C-GETTER conventions for "getter function". This PR renames
env::get_cycle_counttoenv::cycle_countto follow these guidelineshttps://rust-lang.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter