Suppress the "skipping duplicate package xgboost" warning
#1340
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
could not reproduce the following CI error locally.
|
|
Could you update the copyright header's year on each of the effected files? |
|
Let me dig out what happens... It is weird. The problem is that the header is indeed correct on the source repo: // Copyright 2024 RISC Zero, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
// |
|
Ok. @flaub I think it should work now. I realized that my previous commit (just added after the CI failure) here that merges the upstream should have fixed the issue. It is related to including the fix of headers in #1317 (comment). |
Head branch was pushed to by a user without write access
|
It appears that Cargo.lock of examples needs to be updated because a new entry would be added: A commit is pushed trying to fix the remaining CI errors. |
|
An automatic run of After you review the changes, a new approval would be needed to rerun the CI. |
|
The only thing that's needed is to run |
weikengchen
force-pushed
the
remove-xgboost-warning
branch
from
b463b2a
to
a8782f2
Compare
|
The requested change has been made. [[package]]
- name = "xgboost"
+ name = "xgboost-example" |
|
Just an update that a new error has appeared. let me take a look as well since we clearly do not want to spend one more PR for this... |
|
A new commit has fixed the same issue about |
|
@weikengchen we can't merge because this is outdated. Could you update your branch so we can merge? |
|
Updated. Realized that one problem with making a PR from organization-owned repo is that I couldn't auto-grant permission to modify to the RISC Zero team... |
If one uses a git path for dependencies of risc0 in Cargo.toml, chances are that the compiler would complain: ``` warning: skipping duplicate package `xgboost` found at `/Users/cusgadmin/.cargo/git/checkouts/risc0-b4649977e2e81438/341a014/examples/xgboost/methods/guest` ``` This is due to xgboost's example repo has the name `xgboost` and its methods/guest also has the name `xgboost`. Since this is a very boring warning but appears to show up frequently, it makes sense to suppress it, by just naming the xgboost example repo differently.
If one uses a git path for dependencies of risc0 in Cargo.toml, chances are that the compiler would complain: ``` warning: skipping duplicate package `xgboost` found at `/Users/cusgadmin/.cargo/git/checkouts/risc0-b4649977e2e81438/341a014/examples/xgboost/methods/guest` ``` This is due to xgboost's example repo has the name `xgboost` and its methods/guest also has the name `xgboost`. Since this is a very boring warning but appears to show up frequently, it makes sense to suppress it, by just naming the xgboost example repo differently.
If one uses a git path for dependencies of risc0 in Cargo.toml, chances are that the compiler would complain:
This is due to xgboost's example repo has the name
xgboostand its methods/guest also has the namexgboost. Since this is a very boring warning but appears to show up frequently, it makes sense to suppress it, by just naming the xgboost example repo differently.