Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin deprecation of Session::resolve #1378

Merged
merged 3 commits into from Jan 25, 2024
Merged

Begin deprecation of Session::resolve #1378

merged 3 commits into from Jan 25, 2024

Conversation

flaub
Copy link
Member

@flaub flaub commented Jan 25, 2024

  • Drop Session::resolve convienence; this function doesn't scale
  • Avoid using resolve to compute cycle counts and pre/post states
  • Use docker feature flag for stark2snark test

* Drop `Session::resolve` convienence; this function doesn't scale
* Avoid using resolve to compute cycle counts and pre/post states
* Use docker feature flag for stark2snark test
@flaub flaub added this to the 0.20.0 milestone Jan 25, 2024
@flaub flaub self-assigned this Jan 25, 2024
Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 4:12pm

@flaub flaub requested a review from SchmErik January 25, 2024 15:36
@flaub flaub changed the title Being deprecation of Session::resolve Begin deprecation of Session::resolve Jan 25, 2024
@flaub flaub merged commit 06e05e9 into main Jan 25, 2024
26 checks passed
@flaub flaub deleted the flaub/fix-cycles branch January 25, 2024 17:05
flaub added a commit that referenced this pull request Jan 25, 2024
* Drop `Session::resolve` convienence; this function doesn't scale
* Avoid using resolve to compute cycle counts and pre/post states
* Use docker feature flag for stark2snark test
flaub added a commit that referenced this pull request Jan 26, 2024
* Drop `Session::resolve` convienence; this function doesn't scale
* Avoid using resolve to compute cycle counts and pre/post states
* Use docker feature flag for stark2snark test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants