Support rust standard library in guest #161
Conversation
Optimize zip downloading for rust library source
|
Unfortunately this also breaks #116 again |
| // This is an alias for either std::Error, or serde's no_std error replacement. | ||
| impl serde::ser::StdError for Error {} |
|
My inclination would be to wait until #116 is fixed upstream since build reproducibility is a larger need than I'm also curious what it would take to get a standard |
|
@jbruestle WDYT? |
|
I am so psyched about std support (and might grab this branch and try out a few things for fun!), but I do also agree that annoyingly for our actual use cases, non-reproducibility is a critical bug, whereas support for std is a hugely valuable but not required feature. I'm a bit concerned that there hasn't been any review on our cargo PR, but it's only been a few day, so I think it's still impolite to poke. It seems likely that it could be OK'd at which point this issue goes away, but I guess overall I'm also of the mindset that we shouldn't land this yet. |
There was a problem hiding this comment.
Going to block this for now, but very interested to see if we can workaround #116 or wait for rust-lang/cargo#10746 to land
|
From https://github.com/rust-lang/cargo/blob/master/CONTRIBUTING.md:
So, it could take some additional work to get this into cargo. :( I'll see if I can figure out another workaround. |
|
Can we also hit up the discussion forum they mention on the page and talk to the devs about what we are doing? Even if we can hack around it, I think this is a case where it's a useful feature for them to put in upstream, and developing relations with the Rust devs is probably a good call. |
Automatically download standard library from risc0's rust repository
Bump current rust nightly channel up to 2022-06-13
Fixes #148