Updating calculator #1661
Merged
Updating calculator #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A suggested solution for #1661 Note that this doesn't actually pass (it doesn't quite hit 100 bits of security) -- I think that's correct and the test should be adjusted, but you would know better than me. Also note how this test uses `DEFAULT_SEGMENT_LIMIT_PO2` where the tests next to it in the same file use `1 << 20`; I kinda like the version in this test, so I left it, but I think we should make all 3 consistent.
pdg744
commented
Apr 17, 2024
pdg744
commented
Apr 17, 2024
pdg744
commented
Apr 17, 2024
|
working on failing tests now -- should be easy fix |
tzerrell
approved these changes
Apr 18, 2024
flaub
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
updates the calculator to report conjectured security based on the ethSTARK toy problem analysis, rather than the conjectured soundness analysis based on the conjectures from ProxGaps/DEEP-FRI.
updates the arithmetic for computing the plonk_plookup_error
adds plonk_plookup_error to the
toy_model_security()functionclarifies the definition of the parameter which was previously called
dNote how this test uses DEFAULT_SEGMENT_LIMIT_PO2 where the tests next to it in the same file use 1 << 20; I [Tim] kinda like the version in this test, so I left it, but I think we should make all 3 consistent.