rust: Add support for parsing ELF files #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkoo
reviewed
Jul 7, 2022
|
Yes, tests are upcoming. I have them but they are in later PRs which include integration with cirgen. |
|
This is a PR that's reminding me we need at least some place to write down itemized threats for our libraries. I don't see a need to block this PR right now, but anything doing parsing of as complex a format as ELF we will want written review and documentation of how we are using the library and potential points for things parser confusion if there's drift between our parser and the VM loader, weird header tricks that could lead to unexpected behavior, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.