Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress towards making zkp field-agnostic #238

Merged
merged 1 commit into from Aug 17, 2022
Merged

Progress towards making zkp field-agnostic #238

merged 1 commit into from Aug 17, 2022

Conversation

shkoo
Copy link
Contributor

@shkoo shkoo commented Aug 16, 2022

  • Define "field::Elem" and "field::ExtElem" types
  • Add test_roots_of_unity and test_field_ops test utils to run basic tests on fields (It sounds like kalen and @tzerell will be working more on tests and documentation)
  • Rename baby bear field (15*2^27) from {Fp, Fp4} to field::baby_bear::{Elem, ExtElem}; Fp and Fp4 are now aliases
  • Change a bunch of Fp and Fp4 calls to use trait items.
  • Remove Fp::invalid, so we don't have to keep this complication for all our fields. (and we weren't using it in rust anyways)

@shkoo
Progress towards making zkp field-agnostic
d242be0 
* Define "field::Elem" and "field::ExtElem" types
* Add test_roots_of_unity and test_field_ops test utils to run basic tests on fields (It sounds like kalen and @tzerell will be working more on tests and documentation)
* Rename baby bear field (15*2^27) from {Fp, Fp4} to field::baby_bear::{Elem, ExtElem}; Fp and Fp4 are now aliases
* Change a bunch of Fp and Fp4 calls to use trait items.
* Remove Fp::invalid, so we don't have to keep this complication for all our fields. (and we weren't using it in rust anyways)
@shkoo shkoo requested review from flaub and tzerrell August 16, 2022 23:35
tzerrell
tzerrell approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@3lkn this is the field genericization API/infrastructure I mentioned.

@shkoo shkoo merged commit 09c3292 into main Aug 17, 2022
@shkoo shkoo deleted the nils/multifield branch August 17, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzerrell tzerrell tzerrell approved these changes

@flaub flaub Awaiting requested review from flaub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shkoo @tzerrell