-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port C++ merkle tests to Rust #243
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5a0c7a7
WIP Port merkle tests
tzerrell f401397
WIP Port merkle tests
tzerrell fc1265f
WIP Separate bad row access test
tzerrell 0622802
WIP make verify::merkle public
tzerrell 095842a
WIP test for valid/invalid Merkle queries
tzerrell c081bf1
Test querying incorrectly
tzerrell e82b1c5
Test manipulated proofs
tzerrell 5c7c899
Test at more sizes
tzerrell ca35d9e
Lint
tzerrell 1a4e0c3
Merge branch 'main' into tzerrell-port-merkle-tests
tzerrell 090e0f9
Lint
tzerrell 4b3ad3d
Add a circuit to ZKP for use in testing
tzerrell 8b735f2
Use test_circuit for merkle tests
tzerrell afa312d
Lint
tzerrell eb17545
Clean warnings
tzerrell 63a5912
Sort deps
tzerrell b057a90
Update lock files
tzerrell ef170dd
Condense `use`
tzerrell 4aa188c
Merge branch 'main' into tzerrell-port-merkle-tests
tzerrell da113ce
Merge branch 'main' into tzerrell-port-merkle-tests
tzerrell 47271fa
Cleanup from review comments
tzerrell b10b188
Update lock files
tzerrell 7b14863
WIP Make separate risc0-circuit-fib crate
tzerrell 0428522
Lint
tzerrell bf1d43e
Revert "WIP Make separate risc0-circuit-fib crate"
tzerrell b2365ff
Lint
tzerrell a463516
Merge branch 'main' into tzerrell-port-merkle-tests
tzerrell 96e1eb1
Upgrade merkle tests for new error handling
tzerrell 209bc83
Lint
tzerrell 1530171
Merge branch 'main' into tzerrell-port-merkle-tests
tzerrell 479b0d8
Update to new HAL API
tzerrell ec9abe2
Remove now-unused test circuit
tzerrell 889b5ac
Update lock file
tzerrell File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ | |
|
||
pub mod adapter; | ||
mod fri; | ||
mod merkle; | ||
pub(crate) mod merkle; | ||
pub mod read_iop; | ||
|
||
use alloc::vec; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine for now but I think in the future we should avoid using panics and instead use
Result
to do error reporting. Panic won't work well in some environments since a panic causes the entire thread to be terminated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests would be cleaner if this was
Result
-based error reporting than panics anyway. I'm tracking down an intermittent failure inthis testthe randomized version of this test anyway -- perhaps the most straightforward approach will be to rewrite the tested code to useResult
s.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi I switched to
Result
-based errors on the verifier side, but not here on the prover side. We should definitely do it eventually, but there is more to be done on the prover side and IMO it's less important on the prover side.