Add "Field" as an associated type in a Hal. #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaub
approved these changes
Aug 25, 2022
tzerrell
approved these changes
Aug 25, 2022
3lkn
approved these changes
Aug 25, 2022
|
This looks great! Minor note: I just merged my documentation which caused a couple of comment-related conflicts. |
This PR cuts off the head of the hydra, and adds calls in a bunch
of places to convert between the BabyBear field (e.g. Fp and Fp4)
and the type-erased version of it (Hal::Field::{Elem,ExtElem}).
As other things get genericized, we can remove these conversion
calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cuts off the head of the hydra, and adds calls in a bunch
of places to convert between the BabyBear field (e.g. Fp and Fp4)
and the type-erased version of it (Hal::Field::{Elem,ExtElem}).
As other things get genericized, we can remove these conversion
calls.