Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies on baby bear from zkp sha code #255

Merged
merged 1 commit into from Aug 25, 2022
Merged

Conversation

shkoo
Copy link
Contributor

@shkoo shkoo commented Aug 25, 2022

No description provided.

@shkoo shkoo requested review from 3lkn and tzerrell August 25, 2022 18:47
@shkoo shkoo marked this pull request as ready for review August 25, 2022 18:47
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bear removal has begun!

@shkoo shkoo merged commit 66f687b into main Aug 25, 2022
@shkoo shkoo deleted the nils/bearless_sha branch August 25, 2022 19:05
Copy link
Contributor

@3lkn 3lkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you solved this by going smaller! Minor non-blocking comment nit included.

Comment on lines +169 to +170
/// represented as plain old data. Pads up to the Sha block
/// boundry, but does not add the standard SHA trailer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// represented as plain old data. Pads up to the Sha block
/// boundry, but does not add the standard SHA trailer.
/// represented as plain old data. Pads up to the SHA block
/// boundary, but does not append the standard SHA trailer.

Just being fussy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants