Move FRI to generic field #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaub
reviewed
Aug 27, 2022
flaub
approved these changes
Aug 30, 2022
tzerrell
commented
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow FRI to work with generic field elems. The bulk of this is methods for representing field elements as sequences of
u32s and providing conversions -- these are used to read and write field elements from the IoP.I also adjusted the Merkle tree tests to work with moderately large elements (of the baby bear field) rather than start from 0, as there were possible errors with casting to a smaller type that wouldn't be caught because all field elements in the merkle tree were small.