Implement check_code for pure-rust verify #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
flaub
commented
Aug 27, 2022
•
flaub
commented
- Workaround SHA circuit bug under pure-prove
- All pure-prove tests are 'passing'
- Add pure-prove tests to CI
- Fix guest build warnings
- Ensure risc0-build treats MethodIDs as being distinct between C++ and pure-prove
- Drop integration tests in favor of pure-prove unit tests
* Workaround SHA circuit bug under pure-prove * All pure-prove tests are 'passing' * Add tests pure-prove to CI * Fix guest build warnings * Ensure risc0-build treats MethodIDs as being distinct between C++ and pure-prove * Drop integration tests in favor of pure-prove unit tests
shkoo
approved these changes
Aug 29, 2022
| // This is intended as a temporary workaround for bugs in the SHA circuit. | ||
| // The hash will still be computed on the host via a GPIO signal, | ||
| // but the polynomial constraints will not be applied to the ZKP. | ||
| // *DO NOT USE IN PRODUCTION* |
There was a problem hiding this comment.
Ugh, but yeah, I guess when we make pure-prove the default we'll notice this when we go to remote the feature.
| const CODE_SIZE: usize = 16; | ||
| #[cfg(feature = "circuit")] | ||
| lazy_static::lazy_static! { | ||
| pub static ref CIRCUIT: risc0_zkvm_circuit::CircuitImpl = |
There was a problem hiding this comment.
Would it work to have CircuitImpl have a constant constructor so we don't have to use lazy_static? Or maybe just "CIRCUIT: risc0_zkvm_circuit::CircuitImpl = CircuitImpl;" so we don't have to modify cirgen?
There was a problem hiding this comment.
I don't know if a constant constructor will ensure that only a single copy is resident in memory. That's the intent with the lazy_static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.