Improve zkp performance #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shkoo
commented
Aug 31, 2022
shkoo
commented
- Add reg_count to taps so verify knows how big to allocate structures
- Change most uses of Vec::new in verify to use Vec::with_capacity to avoid reallocations during filling
- Avoid duplicating stack during proving
- Compute mix powers once instead of over and over again
* Add reg_count to taps so verify knows how big to allocate structures * Change most uses of Vec::new in verify to use Vec::with_capacity to avoid reallocations during filling * Avoid duplicating stack during proving * Compute mix powers once instead of over and over again
flaub
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.