Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial VerifyHal implementation #266

Merged
merged 11 commits into from Sep 2, 2022
Merged

Initial VerifyHal implementation #266

merged 11 commits into from Sep 2, 2022

Conversation

flaub
Copy link
Member

@flaub flaub commented Aug 31, 2022 •
edited

This gets fake verify to run within 10M cycles. This is accomplished by creating a VerifyHal that has the following accelerators:

  • insecure_sha::Impl
  • compute_polynomial (this runs the poly_ext circuit 'microcode')
  • poly_eval

The #[ignored] attribute is now dropped from the recursion test.

@flaub flaub requested review from shkoo and jbruestle August 31, 2022 23:17
@flaub flaub marked this pull request as ready for review August 31, 2022 23:54
@flaub flaub self-assigned this Aug 31, 2022
shkoo
shkoo reviewed Sep 1, 2022
View reviewed changes
Copy link
Contributor

@shkoo shkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

risc0/zkp/rust/src/verify/mod.rs Outdated Show resolved Hide resolved
risc0/zkvm/sdk/rust/methods/verify/src/bin/verify.rs Outdated Show resolved Hide resolved
risc0/zkvm/sdk/rust/guest/src/env.rs Outdated Show resolved Hide resolved
@flaub flaub enabled auto-merge (squash) September 2, 2022 02:00
@flaub flaub merged commit 6882672 into main Sep 2, 2022
@flaub flaub deleted the flaub/verify-hal branch September 2, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shkoo shkoo shkoo approved these changes

@jbruestle jbruestle Awaiting requested review from jbruestle

Assignees

@flaub flaub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flaub @shkoo