Platform cleanup, std and pure-prove #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix sha bug in rust prover
* Fix rust prover sha bug, sha tests now pass * Trim dependencies, less stuff to build in guest * Add some Result propagation * Guest methods can now decide whether they want to be no_std or not, and get the proper panic and alloc error implementations * Merge separate "verify" method crate into regular "inner" method crate
shkoo
force-pushed
the
nils/platform_pure_prove
branch
from
6835226
to
6da7045
Compare
flaub
reviewed
Sep 4, 2022
flaub
reviewed
Sep 4, 2022
| @@ -751,7 +752,7 @@ where | |||
| self.code[CodeIndex::Data1High] = round.1; | |||
| } else { | |||
| self.code[CodeIndex::ShaCtrl] = ONE; | |||
| self.code[CodeIndex::P1] = Fp::new((sha_phase - 64 + 4) as u32); | |||
| self.code[CodeIndex::P1] = Fp::new((sha_phase - 68 + 4) as u32); | |||
flaub
reviewed
Sep 4, 2022
| @@ -120,34 +120,35 @@ impl<'a> ProverImpl<'a> { | |||
| } | |||
|
|
|||
| impl<'a> exec::IoHandler for ProverImpl<'a> { | |||
| fn on_txrx(&mut self, channel: u32, buf: &[u8]) -> Vec<u8> { | |||
| fn on_txrx(&mut self, channel: u32, buf: &[u8]) -> Result<Vec<u8>> { | |||
flaub
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rust prover sha bug, sha tests now pass
Trim dependencies, less stuff to build in guest
Add some Result propagation
Guest methods can now decide whether they want to be no_std or not, and get the proper panic and alloc error implementations
Merge separate "verify" method crate into regular "inner" method crate