Add initial support to profile guest runs #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is accessible with the --prof-out option of r0vm, or by using risc0_zkvm::host::profiler::Profiler. It produces output in a format suitable for use with google's pprof, but does not yet supply full stack traces.
flaub
reviewed
Sep 12, 2022
flaub
reviewed
Sep 12, 2022
risc0/zkvm/sdk/rust/src/host/mod.rs
Outdated
Comment on lines
365
to
379
| let mut prof = | ||
| crate::host::profiler::Profiler::new("multi_test.elf", &elf_contents).unwrap(); | ||
| { | ||
| let opts = ProverOpts::default() | ||
| .with_skip_seal(true) | ||
| .with_trace_callback(prof.make_trace_callback()); | ||
| let mut prover = Prover::new_with_opts(&elf_contents, MULTI_TEST_ID, opts).unwrap(); | ||
| prover.add_input_u32_slice(&[ | ||
| 4, // Generate known profiling trace | ||
| 0, | ||
| ]); | ||
| prover.run().unwrap(); | ||
| } | ||
|
|
||
| prof.finalize(); |
There was a problem hiding this comment.
Can we make the profiler use an RAII pattern?
flaub
reviewed
Sep 12, 2022
…vm package by default.
flaub
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accessible with the --prof-out option of r0vm, or by using risc0_zkvm::host::profiler::Profiler.
It produces output in a format suitable for use with google's pprof, but does not yet supply full stack traces.