Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starting expansion of ZKVM rustdocs #275

Merged
merged 15 commits into from Sep 15, 2022
Merged

Starting expansion of ZKVM rustdocs #275

merged 15 commits into from Sep 15, 2022

Conversation

3lkn
Copy link
Contributor

@3lkn 3lkn commented Sep 13, 2022

No description provided.

tzerrell
tzerrell requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo doc is currently broken and this probably shouldn't land without it running. That said, the problem seems to be on main and not this PR -- we should add cargo doc or a variant to CI, either in this PR or a separate one, to catch this in the future.

tzerrell
tzerrell approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

risc0/zkvm/sdk/rust/guest/src/env.rs Outdated Show resolved Hide resolved
risc0/zkvm/sdk/rust/src/receipt.rs Outdated Show resolved Hide resolved
3lkn and others added 4 commits September 14, 2022 18:55
updating language around HAL in receipt.rs
63cdfe1
@3lkn @tzerrell
Update risc0/zkvm/sdk/rust/guest/src/env.rs
e29cd1a 
Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com>
@3lkn @flaub
Update risc0/zkvm/sdk/rust/guest/src/env.rs
c2b5860 
Co-authored-by: Frank Laub <flaub@risc0.com>
@3lkn @flaub
Update risc0/zkvm/sdk/rust/guest/src/sha.rs
c05df8e 
Co-authored-by: Frank Laub <flaub@risc0.com>
tzerrell
tzerrell requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restoring my change request until the CI issue is resolved (as in my first comment) or we decide a different strategy.

tzerrell
tzerrell approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is happy

@3lkn 3lkn merged commit 145a64f into main Sep 15, 2022
@3lkn 3lkn deleted the 3lkn/env branch September 15, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaub flaub flaub left review comments

@pdg744 pdg744 pdg744 left review comments

@tzerrell tzerrell tzerrell approved these changes

@shkoo shkoo Awaiting requested review from shkoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@3lkn @flaub @tzerrell @pdg744