Use memcpy and memset from musl for performance benefit #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is angry, looks like you need to run rustfmt. |
stskeeps
force-pushed
the
memset-and-memcpy
branch
from
bbe3955
to
d93ce30
Compare
Indeed, it had the right to be annoyed, pushed an update. |
|
That error looks more like some kind of CI/build system/cache error, the commit clearly includes risc0/zkvm/sdk/rust/guest/src/memcpy.s as a path and https://doc.rust-lang.org/std/macro.include_str.html says it's located relative to the current file.. |
stskeeps
force-pushed
the
memset-and-memcpy
branch
from
d93ce30
to
2ee4c5e
Compare
|
Fixed, bazelbuild/rules_rust#459 |
|
Can you include the copyright header in each |
Base: commit 37e18b7bf307fa4a8c745feebfcba54a0ba74f30 - src/string/memcpy.c - src/string/memset.c This was compiled into assembly with: clang-14 -target riscv32 -march=rv32im -O3 -S memcpy.c -nostdlib -fno-builtin -funroll-loops and labels manually updated to not conflict License is MIT, see https://git.musl-libc.org/cgit/musl/tree/COPYRIGHT and indicated in the .s files Signed-off-by: Carsten Munk <carsten@zippie.com>
stskeeps
force-pushed
the
memset-and-memcpy
branch
from
11b4ade
to
2d004a6
Compare
|
Fixes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base: commit 37e18b7bf307fa4a8c745feebfcba54a0ba74f30
This was compiled into assembly with:
clang-14 -target riscv32 -march=rv32im -O3 -S memcpy.c -nostdlib -fno-builtin -funroll-loops
and labels manually updated to not conflict.
License is MIT, see https://git.musl-libc.org/cgit/musl/tree/COPYRIGHT
This work was prompted by slow performance seen in compiler-builtins in Rust being the memcpy/memset:
https://github.com/rust-lang/compiler-builtins/blob/master/src/mem/mod.rs#L25
cargo bench output from risc0/zkvm/sdk/rust, initially ran on baseline of f99fe08 / current main at the time, with all CPUs in performance governor on a Intel(R) Xeon(R) CPU E3-1275 v5 @ 3.60GHz - please confirm independently (impact seen in memset and memcpy benchmarks):
Signed-off-by: Carsten Munk carsten@zippie.com