Another modification to RNG generation to be both constant time, secure, and easy to implement as a circuit. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intoverflow
approved these changes
Dec 20, 2022
pdg744
approved these changes
Dec 20, 2022
flaub
reviewed
Dec 20, 2022
| // Normally, we would use rejection sampling here, but our specialized | ||
| // verifier circuit really wants an O(1) solution to sampling. So instead, we | ||
| // sample [0, 2^192) % P. This is very close to uniform, as we have 2^192 / P | ||
| // full copies of P, with only 2^192%P left over elements in the 'partial' copy |
There was a problem hiding this comment.
Suggested change
| // full copies of P, with only 2^192%P left over elements in the 'partial' copy | |
| // full copies of P, with only `2 ^ 192 % P` left over elements in the 'partial' copy |
flaub
reviewed
Dec 20, 2022
| // Even if we imagined that this failure to reject totally destroys soundess, | ||
| // the probablity of it occuring even once during proving is vanishingly low | ||
| // (for the about 50 samples our current verifier pulls and at a probability of | ||
| // less than2^-161 per sample, this is less than 2^-155). Even if we target |
There was a problem hiding this comment.
Suggested change
| // less than2^-161 per sample, this is less than 2^-155). Even if we target | |
| // less than `2 ^ -161` per sample, this is less than `2 ^ -155`). Even if we target |
flaub
approved these changes
Dec 20, 2022
flaub
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.