Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarifying verification logic #318

Merged
merged 9 commits into from Jan 9, 2023
Merged

clarifying verification logic #318

merged 9 commits into from Jan 9, 2023

Conversation

pdg744
Copy link
Contributor

@pdg744 pdg744 commented Jan 1, 2023

  • Porting bolton's comments from risczero-wip.
  • @jbruestle there are a couple of TODOs here about parts of the verify logic that are still somewhat opaque to me -- hoping to clarify those before landing this.

jbruestle
jbruestle reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@jbruestle jbruestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to some TODOs.

@BoltonBailey
Copy link
Contributor

Thanks Jeremy, your comments have been integrated!

@pdg744 pdg744 merged commit 8df520a into main Jan 9, 2023
@pdg744 pdg744 deleted the paulg/clarifying-verify branch January 9, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbruestle jbruestle jbruestle left review comments

@BoltonBailey BoltonBailey BoltonBailey approved these changes

@intoverflow intoverflow Awaiting requested review from intoverflow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pdg744 @BoltonBailey @jbruestle