[NFC] Refactor code in advance of adding support for alternate hashes #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the abstractions for Hal and VerifyHal so that they depend on 1) The field 2) The 'Hash Suite'. The hash suite in turn determines which hash function is used as well as how RNG in Fiat-Shamir is computed. This is done via two new traits 'ConfigHash' and 'ConfigRng' which provide the smallest possible API surface. These API's are implemented using the existing Sha256 based protocol when the HashSuiteSha256 is selected (and given a device appropriate Sha256 trait). In general, since there are currently no other HashSuite implementation, this entire PR is just a NFC code reorg.