-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword & re-link zkvm README #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
LGTM, though I'm not really sure how to gauge whether the crate references are correct.
Is there a way I can locally preview the revisions to check the links?
Perhaps we should add one or more of the crates.io/docs.rs pages to the link-checker script? |
The crates.io/docs.rs pages only update when we publish a release and so can't be directly checked (including by script). The docs can be built locally ( Edit: Tagging @flaub in case he knows of some tool or technique I'm unaware of. |
We can run a script on any website to check for broken links, no? |
Ah, fair enough. We'd have to adjust some settings (if I understand what |
I don't have any good tools for link checking of docs off the top of my head. |
Since the crate-level readmes appear on both crates.io and docs.rs, reword and adjust the links to be appropriate for both. (Example of the status quo, showing the broken links and misleading language on crates.io: https://crates.io/crates/risc0-zkvm/0.12.0)