-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #381 #391
Merged
Merged
Fix for #381 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2e02e80.
This continues work from #375 * Drop the COMMIT & OUTPUT regions * Increase HEAP & TEXT from 32MB to 64MB each * Add `env::read_slice` for reading raw data from the host. * Add `env::write_slice` for writing raw data to the host. * Add `env::commit_slice` for committing raw data to the journal. * Replace `SYS_COMMIT` with a `SYS_IO` call using a new `SENDRECV_CHANNEL_JOURNAL` channel. * Allow empty journals to compare to either all zeros or the hash of an empty string.
jbruestle
approved these changes
Feb 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to read most of it, definitely some good clean up, didn’t see any issues.
This was referenced Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues work from #375
env::read_slice
for reading raw data from the host.env::write_slice
for writing raw data to the host.env::commit_slice
for committing raw data to the journal.SYS_COMMIT
with aSYS_IO
call using a newSENDRECV_CHANNEL_JOURNAL
channel.