Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #381 #391

Merged
merged 17 commits into from
Feb 18, 2023
Merged

Fix for #381 #391

merged 17 commits into from
Feb 18, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Feb 18, 2023

This continues work from #375

  • Drop the COMMIT & OUTPUT regions
  • Increase HEAP & TEXT from 32MB to 64MB each
  • Add env::read_slice for reading raw data from the host.
  • Add env::write_slice for writing raw data to the host.
  • Add env::commit_slice for committing raw data to the journal.
  • Replace SYS_COMMIT with a SYS_IO call using a new SENDRECV_CHANNEL_JOURNAL channel.
  • Allow empty journals to compare to either all zeros or the hash of an empty string.

nategraf and others added 13 commits February 2, 2023 16:17
This continues work from #375

* Drop the COMMIT & OUTPUT regions
* Increase HEAP & TEXT from 32MB to 64MB each
* Add `env::read_slice` for reading raw data from the host.
* Add `env::write_slice` for writing raw data to the host.
* Add `env::commit_slice` for committing raw data to the journal.
* Replace `SYS_COMMIT` with a `SYS_IO` call using a new `SENDRECV_CHANNEL_JOURNAL` channel.
* Allow empty journals to compare to either all zeros or the hash of an empty string.
@flaub flaub self-assigned this Feb 18, 2023
@flaub flaub requested review from jbruestle, nategraf, SchmErik and shkoo and removed request for jbruestle February 18, 2023 00:16
@flaub flaub marked this pull request as ready for review February 18, 2023 00:16
@flaub flaub requested a review from tzerrell February 18, 2023 01:44
Copy link
Contributor

@jbruestle jbruestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to read most of it, definitely some good clean up, didn’t see any issues.

@flaub flaub merged commit cc2be3d into main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants