Use tempdir_in OUT_DIR to prevent cross-fs-unlink #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaub
approved these changes
Feb 22, 2023
|
You might need to use the same technique here: https://github.com/risc0/risc0/blob/main/risc0/build_kernel/src/lib.rs#L224 |
Good catch, I will fix that one and do a once over for other tmpdirs that I might have missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating a tempdir within the $OUT_DIR we can prevent cross-fs unlink issues if someone has /tmp mounted as tmpfs or on a different filesystem.