Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update memory map and drop unused code #491

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Update memory map and drop unused code #491

merged 2 commits into from
Apr 4, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Mar 31, 2023

No description provided.

@flaub flaub requested review from shkoo and jbruestle March 31, 2023 20:45
@flaub flaub self-assigned this Mar 31, 2023
@github-actions
Copy link

Benchmark for Linux-cuda e1c414d

Click to hide benchmark
Test Base PR %
fib/100/proof 646.1±6.59ms 639.7±5.99ms -0.99%
fib/100/run 300.8±5.05ms 298.7±5.20ms -0.70%
fib/200/proof 653.0±10.11ms 644.5±8.30ms -1.30%
fib/200/run 305.5±7.58ms 300.0±4.08ms -1.80%

Benchmark for Linux-default e1c414d

Click to hide benchmark
Test Base PR %
fib/100/proof 2.3±0.02s 2.3±0.03s 0.00%
fib/100/run 339.4±1.17ms 330.8±1.79ms -2.53%
fib/200/proof 2.3±0.02s 2.3±0.01s 0.00%
fib/200/run 352.6±4.87ms 339.8±10.08ms -3.63%

Benchmark for macOS-default e1c414d

Click to hide benchmark
Test Base PR %
fib/100/proof 1606.9±14.93ms 1604.9±8.69ms -0.12%
fib/100/run 118.0±0.76ms 116.8±0.59ms -1.02%
fib/200/proof 1612.6±7.31ms 1609.5±5.25ms -0.19%
fib/200/run 118.4±0.30ms 118.1±0.70ms -0.25%

Benchmark for macOS-metal e1c414d

Click to hide benchmark
Test Base PR %
fib/100/proof 463.9±4.90ms 462.5±5.07ms -0.30%
fib/100/run 112.6±0.70ms 112.2±0.47ms -0.36%
fib/200/proof 467.1±6.30ms 462.9±3.52ms -0.90%
fib/200/run 114.4±0.66ms 114.2±0.73ms -0.17%

@flaub flaub enabled auto-merge (squash) April 4, 2023 19:32
@flaub flaub merged commit c657ca0 into main Apr 4, 2023
10 checks passed
@flaub flaub deleted the flaub/fix-memory branch April 4, 2023 19:44
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Benchmark for Linux-cuda 3e69394

Click to hide benchmark
Test Base PR %
fib/100/proof 760.7±48.04ms 718.5±11.54ms -5.55%
fib/100/run 316.0±13.40ms 295.2±8.06ms -6.58%
fib/200/proof 744.8±43.96ms 718.5±13.93ms -3.53%
fib/200/run 322.8±11.03ms 297.5±10.55ms -7.84%

Benchmark for Linux-default 3e69394

Click to hide benchmark
Test Base PR %
fib/100/proof 2.3±0.03s 2.3±0.03s 0.00%
fib/100/run 336.9±4.34ms 325.8±4.34ms -3.29%
fib/200/proof 2.3±0.02s 2.3±0.01s 0.00%
fib/200/run 339.1±4.26ms 335.0±10.37ms -1.21%

Benchmark for macOS-default 3e69394

Click to hide benchmark
Test Base PR %
fib/100/proof 1609.8±23.83ms 1598.0±21.67ms -0.73%
fib/100/run 110.7±0.28ms 110.4±0.39ms -0.27%
fib/200/proof 1602.0±8.26ms 1601.1±9.64ms -0.06%
fib/200/run 112.5±0.44ms 112.3±0.66ms -0.18%

Benchmark for macOS-metal 3e69394

Click to hide benchmark
Test Base PR %
fib/100/proof 464.0±6.18ms 461.8±4.16ms -0.47%
fib/100/run 112.6±0.23ms 111.8±0.44ms -0.71%
fib/200/proof 465.6±5.67ms 464.5±3.53ms -0.24%
fib/200/run 114.6±0.48ms 113.6±0.56ms -0.87%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants