Added RISC0_CUDA_OPT and set ptxas opt level to -O1 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added -O1 because it imporve the cuda build times from 2-5 hours -> ~10-20 minutes/ The performance cost is only ~5-10% slower which should be fine for all our CI, dev, and test but provided the env-var to overwrite that default for production builds.
Benchmark for Linux-cuda 2d197e3Click to hide benchmark
Benchmark for Linux-default 2d197e3Click to hide benchmark
Benchmark for macOS-default 2d197e3Click to hide benchmark
Benchmark for macOS-metal 2d197e3Click to hide benchmark
|
flaub
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added -O1 because it improves the cuda build times from 2-5 hours -> ~10-20 minutes. The performance cost is only ~ 5-10% slower which should be fine for all our CI, dev, and test but provided the env-var to overwrite that default for production builds.