-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash function cleanups #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move hashing functions into `risc0_zkp::hash` * Rename `ConfigHash` to `HashFn` * Renamed `ConfigRng` to `Rng`
Benchmark for Linux-cuda c4fa2f7Click to hide benchmark
Benchmark for Linux-default c4fa2f7Click to hide benchmark
Benchmark for macOS-default c4fa2f7Click to hide benchmark
Benchmark for macOS-metal c4fa2f7Click to hide benchmark
|
tzerrell
reviewed
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API adjustments seem reasonable to me.
I can let people more involved in the implementation speak up in their reviews if they have any concerns with how the implementations were moved / adjusted.
jbruestle
approved these changes
Apr 5, 2023
Benchmark for Linux-cuda 5e2b3c6Click to hide benchmark
Benchmark for Linux-default 5e2b3c6Click to hide benchmark
Benchmark for macOS-default 5e2b3c6Click to hide benchmark
Benchmark for macOS-metal 5e2b3c6Click to hide benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
risc0_zkp::hash
ConfigHash
toHashFn
ConfigRng
toRng