New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved tempdir for risc0-build into cache_dir #497

Merged

flaub merged 2 commits into main from parker/cache-tmpdir

Apr 4, 2023

Contributor

mothran commented Apr 4, 2023

Fixes #496


          Moved tempdir for risc0-build into cache_dir

870393b

mothran requested a review from flaub

April 4, 2023 23:02


          Merge branch 'main' into parker/cache-tmpdir

c6e7c70

flaub approved these changes

View reviewed changes

mothran mentioned this pull request

risc0-build fails to rename a downloaded file across different filesystems #496

Closed

flaub enabled auto-merge (squash)

April 4, 2023 23:08

github-actions bot commented Apr 4, 2023

Benchmark for Linux-cuda `d24f1b9`

Click to hide benchmark

Test	Base	PR	%
fib/100/proof	778.0±44.10ms	730.1±25.98ms	-6.16%
fib/100/run	340.1±21.73ms	309.8±4.53ms	-8.91%
fib/200/proof	799.0±55.82ms	766.0±19.31ms	-4.13%
fib/200/run	329.0±13.24ms	311.8±5.16ms	-5.23%

Benchmark for Linux-default `d24f1b9`

Click to hide benchmark

Test	Base	PR	%
fib/100/proof	2.3±0.01s	2.3±0.01s	0.00%
fib/100/run	326.8±3.98ms	318.1±2.29ms	-2.66%
fib/200/proof	2.3±0.01s	2.3±0.01s	0.00%
fib/200/run	337.2±1.14ms	317.2±0.66ms	-5.93%

Benchmark for macOS-default `d24f1b9`

Click to hide benchmark

Test	Base	PR	%
fib/100/proof	1596.7±13.51ms	1595.1±7.91ms	-0.10%
fib/100/run	110.7±0.41ms	109.8±0.33ms	-0.81%
fib/200/proof	1612.6±25.81ms	1601.7±13.73ms	-0.68%
fib/200/run	112.4±0.55ms	112.1±1.14ms	-0.27%

Benchmark for macOS-metal `d24f1b9`

Click to hide benchmark

Test	Base	PR	%
fib/100/proof	465.4±8.39ms	462.6±2.56ms	-0.60%
fib/100/run	113.1±0.57ms	112.0±0.54ms	-0.97%
fib/200/proof	465.3±4.79ms	462.5±3.44ms	-0.60%
fib/200/run	114.9±0.59ms	113.7±0.53ms	-1.04%

flaub merged commit b54a0b3 into main

10 checks passed

flaub deleted the parker/cache-tmpdir branch

April 4, 2023 23:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment