Fixes risc0-build deadlocks on large outputs #498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if we had a large volume of
cargo build
errors it would hit the piped limit of the child process terminate. By calling cmd.status() we would invoke a second version of the subprocess. Using the spawn() return value and .wait() means we correctly pull from the right piped IO.This might have also fixed double-invoking the
cargo build
child process but I am not 100% sure on that.