Keep CUDA context alive #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mothran
reviewed
Apr 24, 2023
| @@ -42,6 +43,15 @@ use crate::{ | |||
|
|
|||
| const KERNELS_FATBIN: &[u8] = include_bytes!(env!("ZKP_CUDA_PATH")); | |||
|
|
|||
| lazy_static! { | |||
| static ref CONTEXT: Context = { | |||
| let device = Device::get_device(0).unwrap(); | |||
There was a problem hiding this comment.
Could we have a ENV var with a default of 0 could be useful for future multi-GPU hosts.
There was a problem hiding this comment.
Yes, I plan to do that in the future
mothran
approved these changes
Apr 24, 2023
Benchmark for Linux-cuda 91b0ba7Click to hide benchmark
Benchmark for Linux-default 91b0ba7Click to hide benchmark
Benchmark for macOS-default 91b0ba7Click to hide benchmark
Benchmark for macOS-metal 91b0ba7Click to hide benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.