Make MemoryImage::new() failable + bound check #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaub
reviewed
Apr 25, 2023
risc0/zkvm/src/binfmt/image.rs
Outdated
| } | ||
| buf[addr..(WORD_SIZE + addr)].copy_from_slice(&bytes[..WORD_SIZE]); |
There was a problem hiding this comment.
Suggested change
| buf[addr..(WORD_SIZE + addr)].copy_from_slice(&bytes[..WORD_SIZE]); | |
| buf.as_slice().get(addr..(WORD_SIZE + addr))?.copy_from_slice(&bytes[..WORD_SIZE]); |
There was a problem hiding this comment.
good call, we could drop the if + bail! then right?
There was a problem hiding this comment.
err I guess that would remove the friendly Error string
There was a problem hiding this comment.
Combined the two here: d610dc2
flaub
approved these changes
Apr 25, 2023
Benchmark for Linux-cuda 54bb7eaClick to hide benchmark
Benchmark for Linux-default 54bb7eaClick to hide benchmark
Benchmark for macOS-default 54bb7eaClick to hide benchmark
Benchmark for macOS-metal 54bb7eaClick to hide benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531