-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always provide risc0_zkvm::guest module for easier analyzing, even when not on target=zkvm #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shkoo
commented
May 3, 2023
- This allows rust-analyzer to analyze guest code without having to configure it to cross compile for the zkvm target.
- Fixed flaky integration test by remapping absolute pathnames to relative pathnames when compiling the guest
shkoo
force-pushed
the
nils/paths-and-targets
branch
from
May 3, 2023 19:36
1f98946
to
c26ff40
Compare
…en not on target=zkvm * This allows rust-analyzer to analyze guest code without having to configure it to cross compile for the zkvm target. * Fixed flaky integration test by remapping absolute pathnames to relative pathnames when compiling the guest
shkoo
force-pushed
the
nils/paths-and-targets
branch
from
May 3, 2023 19:54
c26ff40
to
69b414d
Compare
Benchmark for Linux-cuda 784214bClick to hide benchmark
Benchmark for Linux-default 784214bClick to hide benchmark
Benchmark for macOS-default 784214bClick to hide benchmark
Benchmark for macOS-metal 784214bClick to hide benchmark
|
mothran
approved these changes
May 3, 2023
mothran
reviewed
May 3, 2023
Is there a way to add CI tests to ensure this doesn't get broken in the future? |
Benchmark for Linux-cuda 9e1b297Click to hide benchmark
Benchmark for Linux-default
Benchmark for macOS-default 9e1b297Click to hide benchmark
Benchmark for macOS-metal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.