Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always provide risc0_zkvm::guest module for easier analyzing, even when not on target=zkvm #546

Merged
merged 3 commits into from
May 3, 2023

Conversation

shkoo
Copy link
Contributor

@shkoo shkoo commented May 3, 2023

  • This allows rust-analyzer to analyze guest code without having to configure it to cross compile for the zkvm target.
  • Fixed flaky integration test by remapping absolute pathnames to relative pathnames when compiling the guest

…en not on target=zkvm

* This allows rust-analyzer to analyze guest code without having to configure it to cross compile for the zkvm target.
* Fixed flaky integration test by remapping absolute pathnames to relative pathnames when compiling the guest
@github-actions
Copy link

github-actions bot commented May 3, 2023

Benchmark for Linux-cuda 784214b

Click to hide benchmark
Test Base PR %
fib/100/execute 354.3±3.59ms 350.7±4.69ms -1.02%
fib/100/prove 1750.0±110.02ms 1576.5±179.20ms -9.91%
fib/100/total 1938.8±125.35ms 1893.8±145.02ms -2.32%
fib/1000/execute 366.7±3.12ms 303.2±3.54ms -17.32%
fib/1000/prove 1824.9±96.97ms 1698.1±148.98ms -6.95%
fib/1000/total 2.1±0.16s 1994.9±194.82ms -5.00%
fib/10000/execute 476.0±6.74ms 471.2±1.10ms -1.01%
fib/10000/prove 5.1±0.27s 4.9±0.39s -3.92%
fib/10000/total 5.5±0.43s 5.1±0.23s -7.27%

Benchmark for Linux-default 784214b

Click to hide benchmark
Test Base PR %
fib/100/execute 1442.2±3.89ms 1436.7±5.59ms -0.38%
fib/100/prove 5.8±0.12s 5.8±0.07s 0.00%
fib/100/total 7.2±0.05s 7.2±0.10s 0.00%
fib/1000/execute 1460.7±2.79ms 1451.3±7.32ms -0.64%
fib/1000/prove 5.9±0.10s 5.9±0.06s 0.00%
fib/1000/total 7.4±0.10s 7.3±0.08s -1.35%
fib/10000/execute 1600.1±23.78ms 1595.9±4.34ms -0.26%
fib/10000/prove 22.0±0.09s 21.9±0.07s -0.45%
fib/10000/total 23.6±0.15s 23.6±0.13s 0.00%

Benchmark for macOS-default 784214b

Click to hide benchmark
Test Base PR %
fib/100/execute 686.2±1.05ms 685.5±0.99ms -0.10%
fib/100/prove 3.8±0.06s 3.7±0.07s -2.63%
fib/100/total 4.5±0.07s 4.4±0.05s -2.22%
fib/1000/execute 691.9±1.33ms 691.5±1.82ms -0.06%
fib/1000/prove 3.8±0.09s 3.8±0.04s 0.00%
fib/1000/total 4.5±0.06s 4.5±0.07s 0.00%
fib/10000/execute 754.4±1.81ms 754.2±2.02ms -0.03%
fib/10000/prove 15.3±0.17s 15.3±0.14s 0.00%
fib/10000/total 16.1±0.07s 16.1±0.14s 0.00%

Benchmark for macOS-metal 784214b

Click to hide benchmark
Test Base PR %
fib/100/execute 686.0±1.98ms 685.5±1.14ms -0.07%
fib/100/prove 915.3±3.26ms 908.4±3.16ms -0.75%
fib/100/total 1630.2±5.51ms 1623.8±6.52ms -0.39%
fib/1000/execute 692.7±1.63ms 692.3±1.59ms -0.06%
fib/1000/prove 934.6±3.32ms 927.1±4.22ms -0.80%
fib/1000/total 1656.2±21.32ms 1651.2±6.63ms -0.30%
fib/10000/execute 755.6±1.18ms 755.0±2.84ms -0.08%
fib/10000/prove 3.4±0.02s 3.4±0.02s 0.00%
fib/10000/total 4.2±0.01s 4.2±0.01s 0.00%

@shkoo shkoo marked this pull request as ready for review May 3, 2023 21:07
@shkoo shkoo requested a review from mothran May 3, 2023 21:08
@shkoo shkoo enabled auto-merge (squash) May 3, 2023 21:13
@flaub
Copy link
Member

flaub commented May 3, 2023

Is there a way to add CI tests to ensure this doesn't get broken in the future?

@shkoo shkoo merged commit 2ee4d20 into main May 3, 2023
12 checks passed
@shkoo shkoo deleted the nils/paths-and-targets branch May 3, 2023 21:40
@github-actions
Copy link

github-actions bot commented May 3, 2023

Benchmark for Linux-cuda 9e1b297

Click to hide benchmark
Test Base PR %
fib/100/execute 351.4±4.34ms 290.8±2.68ms -17.25%
fib/100/prove 1765.0±122.19ms 1618.1±135.48ms -8.32%
fib/100/total 2.1±0.11s 1930.5±139.05ms -8.07%
fib/1000/execute 367.7±1.67ms 362.1±4.77ms -1.52%
fib/1000/prove 1805.2±74.93ms 1707.3±141.92ms -5.42%
fib/1000/total 2.1±0.13s 2.0±0.08s -4.76%
fib/10000/execute 478.2±3.61ms 477.2±3.84ms -0.21%
fib/10000/prove 5.1±0.22s 5.0±0.29s -1.96%
fib/10000/total 5.6±0.21s 5.4±0.28s -3.57%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 9e1b297

Click to hide benchmark
Test Base PR %
fib/100/execute 704.4±1.26ms 685.9±1.34ms -2.63%
fib/100/prove 3.7±0.04s 3.7±0.07s 0.00%
fib/100/total 4.5±0.05s 4.4±0.04s -2.22%
fib/1000/execute 708.6±4.87ms 692.1±0.87ms -2.33%
fib/1000/prove 3.8±0.07s 3.7±0.06s -2.63%
fib/1000/total 4.5±0.05s 4.5±0.06s 0.00%
fib/10000/execute 762.8±6.95ms 754.4±0.55ms -1.10%
fib/10000/prove 15.3±0.15s 15.2±0.08s -0.65%
fib/10000/total 16.0±0.14s 16.0±0.09s 0.00%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants