Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crypto-bigint instead of num-bigint #547

Merged
merged 6 commits into from
May 10, 2023
Merged

Conversation

nategraf
Copy link
Contributor

@nategraf nategraf commented May 4, 2023

As part of working on the interfaces to the bigint accelerator, I am switching usages of
num-bigint to crypto-bigint, which is better suited to the fixed-width computations we intend.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default ec1f0de

Click to hide benchmark
Test Base PR %
fib/100/execute 695.7±9.27ms 686.3±1.22ms -1.35%
fib/100/prove 3.8±0.08s 3.7±0.06s -2.63%
fib/100/total 4.5±0.04s 4.4±0.08s -2.22%
fib/1000/execute 692.1±1.02ms 691.8±0.96ms -0.04%
fib/1000/prove 3.8±0.03s 3.7±0.07s -2.63%
fib/1000/total 4.5±0.05s 4.5±0.06s 0.00%
fib/10000/execute 756.0±1.34ms 754.5±1.09ms -0.20%
fib/10000/prove 15.3±0.13s 15.3±0.13s 0.00%
fib/10000/total 16.1±0.08s 16.1±0.15s 0.00%

Benchmark for macOS-metal ec1f0de

Click to hide benchmark
Test Base PR %
fib/100/execute 686.1±1.35ms 685.8±1.38ms -0.04%
fib/100/prove 916.8±4.84ms 912.5±3.25ms -0.47%
fib/100/total 1633.5±5.88ms 1623.8±4.55ms -0.59%
fib/1000/execute 692.3±1.14ms 691.9±0.84ms -0.06%
fib/1000/prove 935.2±3.39ms 930.0±4.62ms -0.56%
fib/1000/total 1652.6±9.15ms 1649.8±7.57ms -0.17%
fib/10000/execute 755.6±1.24ms 754.6±2.04ms -0.13%
fib/10000/prove 3.4±0.01s 3.4±0.02s 0.00%
fib/10000/total 4.2±0.01s 4.2±0.02s 0.00%

@nategraf nategraf requested a review from SchmErik May 5, 2023 15:20
Copy link
Contributor

@SchmErik SchmErik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I have a question but it's more about about the structure of the bigint circuit so I'll ask internally

@SchmErik
Copy link
Contributor

SchmErik commented May 5, 2023

@nategraf it looks like your commits are unverified

@nategraf
Copy link
Contributor Author

nategraf commented May 5, 2023

@nategraf it looks like your commits are unverified

Ah, ya I need to add my new signing key to my account. I'll do that on Monday and before merging this PR.

@nategraf nategraf enabled auto-merge (squash) May 8, 2023 21:43
@nategraf nategraf disabled auto-merge May 8, 2023 21:43
@nategraf nategraf enabled auto-merge (squash) May 8, 2023 21:44
@nategraf nategraf disabled auto-merge May 8, 2023 21:44
@nategraf nategraf enabled auto-merge (squash) May 8, 2023 21:44
@github-actions
Copy link

github-actions bot commented May 8, 2023

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default 9483eb9

Click to hide benchmark
Test Base PR %
fib/100/execute 1425.4±4.62ms 1415.3±2.52ms -0.71%
fib/100/prove 5.8±0.06s 5.8±0.07s 0.00%
fib/100/total 7.2±0.06s 7.2±0.10s 0.00%
fib/1000/execute 1434.6±1.80ms 1426.1±1.85ms -0.59%
fib/1000/prove 5.9±0.11s 5.8±0.09s -1.69%
fib/1000/total 7.3±0.03s 7.2±0.05s -1.37%
fib/10000/execute 1590.9±2.63ms 1572.2±2.49ms -1.18%
fib/10000/prove 22.2±0.08s 22.0±0.10s -0.90%
fib/10000/total 23.7±0.08s 23.6±0.10s -0.42%

Benchmark for macOS-default 9483eb9

Click to hide benchmark
Test Base PR %
fib/100/execute 704.0±1.25ms 685.3±1.08ms -2.66%
fib/100/prove 3.7±0.08s 3.7±0.04s 0.00%
fib/100/total 4.5±0.04s 4.4±0.07s -2.22%
fib/1000/execute 708.3±5.61ms 692.4±1.26ms -2.24%
fib/1000/prove 3.8±0.05s 3.7±0.06s -2.63%
fib/1000/total 4.5±0.06s 4.5±0.04s 0.00%
fib/10000/execute 759.5±8.32ms 756.4±1.77ms -0.41%
fib/10000/prove 15.4±0.07s 15.3±0.09s -0.65%
fib/10000/total 16.2±0.16s 16.1±0.11s -0.62%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default 4ddd30c

Click to hide benchmark
Test Base PR %
fib/100/execute 1436.9±6.59ms 1428.0±6.02ms -0.62%
fib/100/prove 5.8±0.06s 5.8±0.09s 0.00%
fib/100/total 7.3±0.06s 7.2±0.05s -1.37%
fib/1000/execute 1454.4±4.11ms 1440.6±15.30ms -0.95%
fib/1000/prove 5.8±0.04s 5.8±0.05s 0.00%
fib/1000/total 7.4±0.10s 7.3±0.06s -1.35%
fib/10000/execute 1598.7±7.71ms 1581.0±3.04ms -1.11%
fib/10000/prove 22.2±0.12s 22.2±0.10s 0.00%
fib/10000/total 23.8±0.11s 23.8±0.17s 0.00%

Benchmark for macOS-default 4ddd30c

Click to hide benchmark
Test Base PR %
fib/100/execute 686.7±1.26ms 685.5±1.17ms -0.17%
fib/100/prove 3.8±0.05s 3.8±0.05s 0.00%
fib/100/total 4.5±0.06s 4.5±0.09s 0.00%
fib/1000/execute 693.1±1.17ms 691.8±0.96ms -0.19%
fib/1000/prove 3.8±0.08s 3.8±0.04s 0.00%
fib/1000/total 4.5±0.08s 4.5±0.06s 0.00%
fib/10000/execute 754.9±2.26ms 754.3±1.25ms -0.08%
fib/10000/prove 15.3±0.08s 15.3±0.10s 0.00%
fib/10000/total 16.2±0.10s 16.1±0.14s -0.62%

Benchmark for macOS-metal 4ddd30c

Click to hide benchmark
Test Base PR %
fib/100/execute 686.2±1.41ms 685.5±0.84ms -0.10%
fib/100/prove 912.9±4.65ms 908.8±8.10ms -0.45%
fib/100/total 1630.2±3.50ms 1621.8±6.50ms -0.52%
fib/1000/execute 692.2±1.26ms 691.9±1.30ms -0.04%
fib/1000/prove 928.8±4.53ms 923.4±6.35ms -0.58%
fib/1000/total 1654.1±5.93ms 1640.4±4.37ms -0.83%
fib/10000/execute 755.0±1.97ms 754.3±0.89ms -0.09%
fib/10000/prove 3.4±0.01s 3.4±0.02s 0.00%
fib/10000/total 4.2±0.01s 4.2±0.01s 0.00%

@nategraf nategraf merged commit d83c7fe into main May 10, 2023
12 checks passed
@nategraf nategraf deleted the victor/use-crypto-bigint branch May 10, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants