Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious build warning about "duplicate package wordle". #550

Merged
merged 1 commit into from
May 10, 2023

Conversation

choongng
Copy link
Contributor

@choongng choongng commented May 8, 2023

It appears having two packages with the same name can cause this error even when they are (I think) not built for the same target. Fix by renaming the guest code in the wordle example. Tests for wordle pass.

@choongng choongng requested review from flaub and mothran May 8, 2023 18:24
Copy link
Contributor

@mothran mothran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@flaub flaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@flaub
Copy link
Member

flaub commented May 8, 2023

@tzerrell Could you ensure this is documented someplace?

@choongng
Copy link
Contributor Author

choongng commented May 8, 2023

I see the CUDA machine failed CI but it doesn't seem like there's any possible way this is related. What should I do in this situation?

@mothran
Copy link
Contributor

mothran commented May 8, 2023

I see the CUDA machine failed CI but it doesn't seem like there's any possible way this is related. What should I do in this situation?

known issue in the CI right now, working up a patchwork fix now.

@choongng choongng merged commit ca3f02d into main May 10, 2023
8 checks passed
@choongng choongng deleted the choong/fix-wordle-warning branch May 10, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants