Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update criterion requirement from 0.4 to 0.5 #586

Merged
merged 2 commits into from
May 26, 2023
Merged

Update criterion requirement from 0.4 to 0.5 #586

merged 2 commits into from
May 26, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 24, 2023

Updates the requirements on criterion to permit the latest version.

Changelog

Sourced from criterion's changelog.

[0.5.0] - 2023-05-23

Changed

  • Replaced lazy_static dependency with once_cell
  • Improved documentation of the html_reports feature
  • Replaced atty dependency with is-terminal
  • MSRV bumped to 1.64
  • Upgraded clap dependency to v4
  • Upgraded tempfile dependency to v3.5.0

Fixed

  • Quick mode (--quick) no longer outputs 1ms for measured times over 5 seconds
  • Documentation updates

[0.4.0] - 2022-09-10

Removed

  • The Criterion::can_plot function has been removed.
  • The Criterion::bench_function_over_inputs function has been removed.
  • The Criterion::bench_functions function has been removed.
  • The Criterion::bench function has been removed.

Changed

  • HTML report hidden behind non-default feature flag: 'html_reports'
  • Standalone support (ie without cargo-criterion) feature flag: 'cargo_bench_support'
  • MSRV bumped to 1.57
  • rayon and plotters are optional (and default) dependencies.
  • Status messages ('warming up', 'analyzing', etc) are printed to stderr, benchmark results are printed to stdout.
  • Accept subsecond durations for --warm-up-time, --measurement-time and --profile-time.
  • Replaced serde_cbor with ciborium because the former is no longer maintained.
  • Upgrade clap to v3 and regex to v1.5.

Added

  • A --discard-baseline flag for discarding rather than saving benchmark results.
  • Formal support for benchmarking code compiled to web-assembly.
  • A --quiet flag for printing just a single line per benchmark.
  • A Throughput::BytesDecimal option for measuring throughput in bytes but printing them using decimal units like kilobytes instead of binary units like kibibytes.

Fixed

  • When using bench_with_input, the input parameter will now be passed through black_box before passing it to the benchmark.

[0.3.6] - 2022-07-06

Changed

  • MSRV bumped to 1.49
  • Symbol for microseconds changed from ASCII 'us' to unicode 'µs'

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update criterion requirement from 0.4 to 0.5
e58d294 
Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version.
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](bheisler/criterion.rs@0.4.0...0.5.0)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 24, 2023
@github-actions
Copy link

Benchmark for Linux-cuda 3fe3828

Click to hide benchmark
Test Base PR %
fib/100/execute 17.6±0.65ms 17.2±0.52ms -2.27%
fib/100/prove 1067.1±89.06ms 1025.4±48.49ms -3.91%
fib/100/total 1091.6±29.32ms 1051.6±33.20ms -3.66%
fib/1000/execute 33.7±0.51ms 33.6±0.84ms -0.30%
fib/1000/prove 1094.2±24.47ms 1086.4±40.95ms -0.71%
fib/1000/total 1112.8±42.49ms 1063.2±42.47ms -4.46%
fib/10000/execute 201.3±3.26ms 199.9±3.25ms -0.70%
fib/10000/prove 3.8±0.11s 3.8±0.13s 0.00%
fib/10000/total 4.1±0.19s 4.0±0.09s -2.44%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 3fe3828

Click to hide benchmark
Test Base PR %
fib/100/execute 29.4±0.13ms 29.2±0.07ms -0.68%
fib/100/prove 3.7±0.05s 3.7±0.06s 0.00%
fib/100/total 3.7±0.06s 3.7±0.06s 0.00%
fib/1000/execute 40.2±0.10ms 39.5±0.09ms -1.74%
fib/1000/prove 3.7±0.05s 3.7±0.07s 0.00%
fib/1000/total 3.8±0.06s 3.7±0.06s -2.63%
fib/10000/execute 148.8±0.22ms 144.4±0.16ms -2.96%
fib/10000/prove 15.3±0.10s 15.3±0.17s 0.00%
fib/10000/total 15.5±0.16s 15.4±0.10s -0.65%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@flaub flaub enabled auto-merge (squash) May 26, 2023 17:54
@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default b8ba849

Click to hide benchmark
Test Base PR %
fib/100/execute 29.9±0.07ms 29.2±0.12ms -2.34%
fib/100/prove 3.7±0.06s 3.7±0.03s 0.00%
fib/100/total 3.7±0.06s 3.7±0.06s 0.00%
fib/1000/execute 40.8±0.11ms 39.8±0.10ms -2.45%
fib/1000/prove 3.7±0.05s 3.7±0.06s 0.00%
fib/1000/total 3.8±0.03s 3.8±0.08s 0.00%
fib/10000/execute 147.2±0.40ms 146.0±0.23ms -0.82%
fib/10000/prove 15.3±0.15s 15.2±0.13s -0.65%
fib/10000/total 15.4±0.11s 15.4±0.11s 0.00%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@flaub flaub merged commit 3a8d4c2 into main May 26, 2023
12 checks passed
@flaub flaub deleted the dependabot/cargo/criterion-0.5 branch May 26, 2023 18:31
hashcashier pushed a commit that referenced this pull request Jun 16, 2023
@dependabot @hashcashier
Update criterion requirement from 0.4 to 0.5 (#586)
0564c08 
Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version.
- [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md)
- [Commits](bheisler/criterion.rs@0.4.0...0.5.0)

---
updated-dependencies:
- dependency-name: criterion
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaub flaub flaub approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@flaub