Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added first draft of bonsai-alpha SDK #606

Merged
merged 11 commits into from
Jun 14, 2023
Merged

Added first draft of bonsai-alpha SDK #606

merged 11 commits into from
Jun 14, 2023

Conversation

mothran
Copy link
Contributor

@mothran mothran commented Jun 6, 2023

Adding a new bonsai top level directory to organize bonsai public crates into and added the bonsai-alpha / bonsai-serverless SDK as the first crate.

I added unit tests with a mocked REST api as well as a README with example usage and docstrings for all exposed methods. Currently the README docstring does not build and run because it pulls in a lot of deps that are:

  • Coming in a pending PR: Publish Recursion Verifier #603
  • Or not used anywhere else in the build, might make sense to make them dev-dependencies depending on if we just want a building but no_run example.

@mothran mothran requested review from flaub, tzerrell and 3lkn June 6, 2023 00:21
@mothran mothran marked this pull request as ready for review June 6, 2023 16:15
add `#[cfg(not(target_os = "zkvm"))]` to items that are not needed for guest compilation
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Benchmark for Linux-cuda 49d5a4b

Click to hide benchmark
Test Base PR %
fib/100/execute 18.2±0.56ms 18.0±0.59ms -1.10%
fib/100/prove 1033.3±43.97ms 1008.4±52.08ms -2.41%
fib/100/total 1070.3±39.50ms 1059.6±36.05ms -1.00%
fib/1000/execute 35.8±0.61ms 35.1±0.63ms -1.96%
fib/1000/prove 1069.4±39.19ms 1052.9±44.37ms -1.54%
fib/1000/total 1111.2±39.69ms 1059.9±38.62ms -4.62%
fib/10000/execute 210.6±3.00ms 208.7±2.76ms -0.90%
fib/10000/prove 4.0±0.12s 3.9±0.12s -2.50%
fib/10000/total 4.1±0.11s 4.0±0.07s -2.44%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@mothran mothran requested a review from Wollac June 9, 2023 20:27
@flaub flaub enabled auto-merge (squash) June 14, 2023 06:04
@flaub flaub merged commit d67e377 into main Jun 14, 2023
8 of 9 checks passed
@flaub flaub deleted the parker/bonsai-alpha-sdk branch June 14, 2023 06:38
flaub added a commit that referenced this pull request Jun 14, 2023
* Added first draft of bonsai-alpha SDK

* Added license header

* Removed bincode in guest dep of bonsai-alpha

* Made the bonsai-alpha crate a module of bonsai-sdk

This will allow for dual SDKs in the same crate

* recursion: fix compiler warning in guest (#614)

add `#[cfg(not(target_os = "zkvm"))]` to items that are not needed for guest compilation

* Added Debug to SessionId

* Potential stability fix and extra derives

---------

Co-authored-by: Erik Kaneda <erik@risczero.com>
Co-authored-by: Frank Laub <flaub@risc0.com>
flaub added a commit that referenced this pull request Jun 15, 2023
* Added first draft of bonsai-alpha SDK

* Added license header

* Removed bincode in guest dep of bonsai-alpha

* Made the bonsai-alpha crate a module of bonsai-sdk

This will allow for dual SDKs in the same crate

* recursion: fix compiler warning in guest (#614)

add `#[cfg(not(target_os = "zkvm"))]` to items that are not needed for guest compilation

* Added Debug to SessionId

* Potential stability fix and extra derives

---------

Co-authored-by: Erik Kaneda <erik@risczero.com>
Co-authored-by: Frank Laub <flaub@risc0.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants