Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes to release-0.15 #619

Merged
merged 13 commits into from
Jun 9, 2023
Merged

Backport changes to release-0.15 #619

merged 13 commits into from
Jun 9, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Jun 9, 2023

No description provided.

pdg744 and others added 13 commits June 8, 2023 22:06
* Update to latest revm; use radium from git

* Fix block number in unit test

* Pin radium to specific rev
Triggers rebuilds for couple more env vars if they change between
invokes of the kernel build
Co-authored-by: Frank Laub <flaub@risc0.com>
* adding graviton to ci

* updating feature label

* retrigger

* triggering only aws runners

* testing graviton runner

* testing graviton runner asg

* adding sccache for Linux ARM

* change to graviton2 & test rest of flows

* testing sscache conditional

* missing complete url

* missing complete file name

* remove .tar.gz from file name

* changing feature to cuda

* testing regular graviton2

* testing python on check

* bumping python version a bit

* testing new ami

* testing sscache

* testing sccache for linux ARM64

* testing sccache

* test

* env var

* testing env sccache

* test run env var

* using env file

* adding multiline

* last run through

* cleanup

* updating sccache version across all

* updating device name

* fixing typo

* removed extra indent
This change moves the recursion verifier from the private repository. This is
done by splitting the `CircuitDef` trait and adding files used by the recursion
verifier.

The CircuitDef is a trait that is implemented by rust code generated from the
circuit for both the verifier and the prover. In order to split off the recursive
verifier, we need to split this trait into two parts: one that is used in both the
prover and the verifier and one that is used only in the prover. The former trait
called `CircuitCoreDef` is implemented for the recursive verifier which requires
generated rust files from the recursion circuit.
add `#[cfg(not(target_os = "zkvm"))]` to items that are not needed for guest compilation
@flaub flaub self-assigned this Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Benchmark for Linux-cuda d0373b7

Click to hide benchmark
Test Base PR %
fib/100/execute 16.7±0.36ms 16.2±0.49ms -2.99%
fib/100/prove 925.4±5.31ms 919.0±11.97ms -0.69%
fib/100/total 965.8±36.31ms 952.1±27.50ms -1.42%
fib/1000/execute 26.4±0.62ms 24.3±0.35ms -7.95%
fib/1000/prove 1007.4±66.98ms 947.1±4.45ms -5.99%
fib/1000/total 1000.8±28.85ms 996.5±29.75ms -0.43%
fib/10000/execute 121.3±2.10ms 107.2±2.45ms -11.62%
fib/10000/prove 3.5±0.02s 3.5±0.05s 0.00%
fib/10000/total 3.7±0.08s 3.6±0.06s -2.70%

Benchmark for Linux-default d0373b7

Click to hide benchmark
Test Base PR %
fib/100/execute 56.7±0.56ms 55.0±1.16ms -3.00%
fib/100/prove 5.1±0.04s 5.0±0.03s -1.96%
fib/100/total 5.1±0.04s 5.1±0.02s 0.00%
fib/1000/execute 70.1±1.40ms 65.8±0.26ms -6.13%
fib/1000/prove 5.1±0.02s 5.1±0.02s 0.00%
fib/1000/total 5.2±0.02s 5.2±0.03s 0.00%
fib/10000/execute 209.6±0.92ms 180.4±1.42ms -13.93%
fib/10000/prove 21.2±0.11s 21.0±0.11s -0.94%
fib/10000/total 21.3±0.21s 21.2±0.08s -0.47%

Benchmark for macOS-default d0373b7

Click to hide benchmark
Test Base PR %
fib/100/execute 29.1±0.08ms 27.6±0.05ms -5.15%
fib/100/prove 3.7±0.04s 3.7±0.06s 0.00%
fib/100/total 3.7±0.06s 3.7±0.04s 0.00%
fib/1000/execute 35.3±0.07ms 33.1±0.06ms -6.23%
fib/1000/prove 3.7±0.04s 3.7±0.05s 0.00%
fib/1000/total 3.7±0.06s 3.7±0.06s 0.00%
fib/10000/execute 99.3±0.24ms 85.4±0.10ms -14.00%
fib/10000/prove 15.3±0.10s 15.1±0.33s -1.31%
fib/10000/total 15.5±0.23s 15.4±0.17s -0.65%

Benchmark for macOS-metal d0373b7

Click to hide benchmark
Test Base PR %
fib/100/execute 28.4±0.09ms 27.6±0.06ms -2.82%
fib/100/prove 851.3±5.05ms 849.1±3.58ms -0.26%
fib/100/total 903.0±6.32ms 902.5±4.67ms -0.06%
fib/1000/execute 34.3±0.10ms 32.9±0.08ms -4.08%
fib/1000/prove 870.3±4.01ms 867.7±5.70ms -0.30%
fib/1000/total 936.0±7.63ms 926.5±5.40ms -1.01%
fib/10000/execute 96.3±0.14ms 85.5±0.27ms -11.21%
fib/10000/prove 3.4±0.01s 3.3±0.01s -2.94%
fib/10000/total 3.4±0.02s 3.4±0.01s 0.00%

@flaub flaub merged commit 99000d1 into release-0.15 Jun 9, 2023
13 checks passed
@flaub flaub deleted the flaub/next branch June 9, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants