Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing pass on starter template readme #693

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Editing pass on starter template readme #693

merged 5 commits into from
Jul 26, 2023

Conversation

pdg744
Copy link
Contributor

@pdg744 pdg744 commented Jul 13, 2023

  • updates link to new version of "Understanding the Starter Template"
  • updates bonsai access pointer to bonsai.xyz/apply (this link isn't live yet but should be later this week)
  • addresses the fact that the TODOs at the top of the README render as a single line in the markdown display version
  • updates link from "Getting Started" section on website to zkvm dev docs

@pdg744 pdg744 marked this pull request as ready for review July 13, 2023 01:06
@pdg744
Copy link
Contributor Author

pdg744 commented Jul 13, 2023

This shouldn't land until https://bonsai.xyz/apply is live

tzerrell
tzerrell reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

templates/rust-starter/README.md Outdated Show resolved Hide resolved
templates/rust-starter/README.md Outdated Show resolved Hide resolved
pdg744 and others added 3 commits July 26, 2023 10:14
@pdg744
Merge branch 'main' into paulg/edits-on-template-readme
8b19860
@pdg744 @tzerrell
removing www
20ade3f 
Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com>
@tzerrell @pdg744
Revise Welcome paragraph
76dc3f7 
Co-authored-by: Paul <paul.gafni@gmail.com>
@pdg744 pdg744 enabled auto-merge (squash) July 26, 2023 18:52
@pdg744 pdg744 merged commit 888ef37 into main Jul 26, 2023
12 checks passed
@pdg744 pdg744 deleted the paulg/edits-on-template-readme branch July 26, 2023 19:03
capossele pushed a commit that referenced this pull request Aug 7, 2023
@pdg744 @tzerrell @capossele
Editing pass on starter template readme (#693)
5127e92 
* editing pass on readme

* removing www

Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com>

* Revise Welcome paragraph

Co-authored-by: Paul <paul.gafni@gmail.com>

---------

Co-authored-by: Tim Zerrell <tim.zerrell@risczero.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzerrell tzerrell tzerrell approved these changes

@3lkn 3lkn Awaiting requested review from 3lkn

@heavypackets heavypackets Awaiting requested review from heavypackets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdg744 @tzerrell