zkVM: split binfmt feature to a new "risc0-binfmt" crate for modularity #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to drop risc0-zkvm as a dependency for risc0-build to avoid future circular dependencies. In order to do so, we introduce a new crate, risc0-binfmt that contains all code needed by risc0-build that used to be a part of risc0-zkvm. This crate contains Program, MemoryImage, and SystemState struct definitions along with several functions that operate on it.
This change removes files that implement MemoryImage, Program, SystemState, and the binfmt feature of risc0-zkvm. Instead, it uses the new risc0-binfmt crate.
SchmErik
force-pushed
the
erik/risc0-binfmt-v2
branch
from
0fc085a
to
84f432e
Compare
SchmErik
force-pushed
the
erik/risc0-binfmt-v2
branch
from
c9bcddf
to
60bd35d
Compare
Benchmark for Linux-cuda 14121a0Click to hide benchmark
Benchmark for Linux-defaultBenchmark for macOS-default 14121a0Click to hide benchmark
Benchmark for macOS-metal 14121a0Click to hide benchmark
|
SchmErik
force-pushed
the
erik/risc0-binfmt-v2
branch
from
562db4a
to
d418cc8
Compare
Benchmark for Linux-cuda 02c1115Click to hide benchmark
Benchmark for Linux-defaultBenchmark for macOS-default 02c1115Click to hide benchmark
Benchmark for macOS-metal 02c1115Click to hide benchmark
|
flaub
reviewed
Jul 19, 2023
flaub
reviewed
Jul 19, 2023
Comment on lines
18
to
19
| tracing = { version = "0.1", default-features = false, features = ["attributes"] } | ||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } |
There was a problem hiding this comment.
Yes, So... oddly enough. This PR made this example fail on cargo test with the following error and adding this helped the test pass. I'm not sure what exactly changed but it fails to compile without these additional deps now.
% cargo test
Compiling risc0-binfmt v0.16.1 (/Users/erik/risc0/risc0/binfmt)
Compiling risc0-build v0.16.1 (/Users/erik/risc0/risc0/build)
Compiling risc0-zkvm v0.16.1 (/Users/erik/risc0/risc0/zkvm)
Compiling digital-signature-methods v0.1.0 (/Users/erik/risc0/examples/digital-signature/methods)
Compiling digital-signature-core v0.1.0 (/Users/erik/risc0/examples/digital-signature/core)
sign: Starting build for riscv32im-risc0-zkvm-elf digital-signature-methods(build), risc0-zkvm
sign: Updating crates.io index
sign: Finished release [optimized] target(s) in 1.37s-signature-methods(build)
Compiling digital-signature v0.1.0 (/Users/erik/risc0/examples/digital-signature)
error[E0433]: failed to resolve: could not find `tracing_subscriber` in the list of imported crates
--> digital-signature/src/lib.rs:72:5
|
72 | #[test]
| ^^^^^^^ could not find `tracing_subscriber` in the list of imported crates
|
= note: this error originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0433]: failed to resolve: could not find `tracing` in the list of imported crates
--> digital-signature/src/lib.rs:72:5
|
72 | #[test]
| ^^^^^^^ could not find `tracing` in the list of imported crates
|
= note: this error originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
For more information about this error, try `rustc --explain E0433`.
error: could not compile `digital-signature` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
flaub
reviewed
Jul 19, 2023
Benchmark for Linux-cuda 4fb7f17Click to hide benchmark
Benchmark for Linux-defaultBenchmark for macOS-default 4fb7f17Click to hide benchmark
Benchmark for macOS-metal 4fb7f17Click to hide benchmark
|
flaub
approved these changes
Jul 20, 2023
Benchmark for Linux-cuda bf89333Click to hide benchmark
Benchmark for Linux-defaultBenchmark for macOS-defaultBenchmark for macOS-metal bf89333Click to hide benchmark
|
capossele
pushed a commit
that referenced
this pull request
Aug 7, 2023
…ty (#725) * Add a new package risc0-binfmt We need to drop risc0-zkvm as a dependency for risc0-build to avoid future circular dependencies. In order to do so, we introduce a new crate, risc0-binfmt that contains all code needed by risc0-build that used to be a part of risc0-zkvm. This crate contains Program, MemoryImage, and SystemState struct definitions along with several functions that operate on it. * drop binfmt feature and use risc0-binfmt instead This change removes files that implement MemoryImage, Program, SystemState, and the binfmt feature of risc0-zkvm. Instead, it uses the new risc0-binfmt crate.
SkymanOne
reviewed
Sep 1, 2023
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| use alloc::collections::BTreeMap; | |||
There was a problem hiding this comment.
This makes risc0_zkvm and risc0_binfmt to be no_std incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits off the
binfmtfeature to a separate crate in order to avoid a circular dependency with a zkVM capability to be added in the near future. This capability requires risc0-zkvm to be dependent on risc0-build and the zkVM crate will contain guest code used in cases where the executor runs into a fault.