Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust risc0-binfmt deps #731

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Adjust risc0-binfmt deps #731

merged 2 commits into from
Jul 21, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Jul 21, 2023

No description provided.

@flaub flaub requested a review from SchmErik July 21, 2023 05:17
@flaub flaub self-assigned this Jul 21, 2023
@flaub flaub enabled auto-merge (squash) July 21, 2023 05:19
@github-actions
Copy link

Benchmark for Linux-cuda 6cbf470

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.09ms 5.1±0.09ms 0.00%
fib/100/prove 954.0±2.01ms 885.9±4.72ms -7.14%
fib/100/total 952.5±1.80ms 885.2±2.78ms -7.07%
fib/1000/execute 5.7±0.10ms 5.7±0.08ms 0.00%
fib/1000/prove 993.6±1.51ms 918.7±3.07ms -7.54%
fib/1000/total 986.9±1.64ms 924.8±3.08ms -6.29%
fib/10000/execute 11.5±0.11ms 11.5±0.11ms 0.00%
fib/10000/prove 3.7±0.02s 3.4±0.01s -8.11%
fib/10000/total 3.7±0.01s 3.5±0.03s -5.41%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 6cbf470

Click to hide benchmark
Test Base PR %
fib/100/execute 2.7±0.08ms 2.7±0.10ms 0.00%
fib/100/prove 3.7±0.07s 3.7±0.04s 0.00%
fib/100/total 3.7±0.06s 3.7±0.06s 0.00%
fib/1000/execute 3.1±0.06ms 2.9±0.05ms -6.45%
fib/1000/prove 3.7±0.05s 3.7±0.07s 0.00%
fib/1000/total 3.7±0.04s 3.7±0.05s 0.00%
fib/10000/execute 5.8±0.12ms 5.5±0.06ms -5.17%
fib/10000/prove 15.3±0.12s 15.2±0.11s -0.65%
fib/10000/total 15.3±0.13s 15.2±0.14s -0.65%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@github-actions
Copy link

Benchmark for Linux-cuda 61b4862

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.10ms 5.1±0.10ms 0.00%
fib/100/prove 1600.6±47.10ms 895.2±4.58ms -44.07%
fib/100/total 1522.6±42.30ms 896.7±5.85ms -41.11%
fib/1000/execute 5.7±0.10ms 5.7±0.09ms 0.00%
fib/1000/prove 1615.2±49.00ms 929.8±3.45ms -42.43%
fib/1000/total 1562.6±4.75ms 937.2±6.29ms -40.02%
fib/10000/execute 11.6±0.16ms 11.5±0.08ms -0.86%
fib/10000/prove 5.0±0.03s 3.6±0.02s -28.00%
fib/10000/total 5.0±0.02s 3.7±0.02s -26.00%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal 61b4862

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.08ms 2.8±0.16ms 0.00%
fib/100/prove 851.3±4.52ms 849.7±4.63ms -0.19%
fib/100/total 883.1±5.98ms 877.0±8.24ms -0.69%
fib/1000/execute 3.0±0.10ms 3.0±0.08ms 0.00%
fib/1000/prove 872.1±5.60ms 871.7±4.75ms -0.05%
fib/1000/total 901.9±4.60ms 896.4±8.40ms -0.61%
fib/10000/execute 5.7±0.04ms 5.7±0.12ms 0.00%
fib/10000/prove 3.3±0.01s 3.3±0.02s 0.00%
fib/10000/total 3.4±0.01s 3.3±0.01s -2.94%

@flaub flaub changed the title Make risc0-binfmt optional dep and fix dev-deps Adjust risc0-binfmt deps Jul 21, 2023
@flaub flaub disabled auto-merge July 21, 2023 07:56
@flaub flaub merged commit 4bf1b84 into main Jul 21, 2023
12 checks passed
@flaub flaub deleted the flaub/locks branch July 21, 2023 07:56
capossele pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant