Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for clippy and add lint to CI #751

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fixes for clippy and add lint to CI #751

merged 2 commits into from
Jul 31, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Jul 29, 2023

No description provided.

@flaub flaub self-assigned this Jul 29, 2023
@flaub flaub enabled auto-merge (squash) July 30, 2023 20:26
@github-actions
Copy link

Benchmark for Linux-cuda 5a0fd5e

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.09ms 5.1±0.09ms 0.00%
fib/100/prove 755.9±1.28ms 742.1±2.76ms -1.83%
fib/100/total 755.3±3.91ms 746.8±2.86ms -1.13%
fib/1000/execute 5.6±0.10ms 5.6±0.10ms 0.00%
fib/1000/prove 779.4±3.98ms 772.9±2.82ms -0.83%
fib/1000/total 783.2±3.85ms 777.0±1.60ms -0.79%
fib/10000/execute 10.2±0.14ms 10.2±0.12ms 0.00%
fib/10000/prove 3.0±0.00s 2.8±0.00s -6.67%
fib/10000/total 3.0±0.01s 2.8±0.00s -6.67%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 5a0fd5e

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.17ms 2.7±0.13ms -3.57%
fib/100/prove 3.7±0.06s 3.7±0.04s 0.00%
fib/100/total 3.7±0.05s 3.7±0.03s 0.00%
fib/1000/execute 3.0±0.09ms 2.9±0.14ms -3.33%
fib/1000/prove 3.7±0.07s 3.7±0.08s 0.00%
fib/1000/total 3.7±0.04s 3.7±0.08s 0.00%
fib/10000/execute 5.1±0.06ms 5.0±0.16ms -1.96%
fib/10000/prove 15.3±0.11s 15.2±0.09s -0.65%
fib/10000/total 15.3±0.10s 15.3±0.09s 0.00%

Benchmark for macOS-metal 5a0fd5e

Click to hide benchmark
Test Base PR %
fib/100/execute 2.7±0.16ms 2.7±0.14ms 0.00%
fib/100/prove 855.4±3.91ms 854.6±5.29ms -0.09%
fib/100/total 877.5±4.09ms 876.9±5.07ms -0.07%
fib/1000/execute 2.9±0.11ms 2.9±0.04ms 0.00%
fib/1000/prove 874.0±4.97ms 870.1±5.87ms -0.45%
fib/1000/total 897.6±7.80ms 895.7±3.08ms -0.21%
fib/10000/execute 5.0±0.07ms 4.9±0.04ms -2.00%
fib/10000/prove 3.4±0.02s 3.3±0.01s -2.94%
fib/10000/total 3.4±0.01s 3.3±0.01s -2.94%

@flaub flaub merged commit 76da671 into main Jul 31, 2023
18 checks passed
@flaub flaub deleted the flaub/clippy branch July 31, 2023 17:20
capossele pushed a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants