Recover non processed blocks after websocket connection loss #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/risc0/risc0 into cardosaum/websocket-reconnection
…com/risc0/risc0 into cardosaum/relay-recover-lost-blocks
capossele
approved these changes
Aug 15, 2023
|
FYI for future reference, when we squash & merge, it'd be good to try and cleanup the final commit message so that in the future, if someone is doing a bisect or looking thru the history, they don't see all of the intermediate commit messages. GitHub provides a way to edit the final commit message just during the squash & merge process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, in case of websocket connection loss, we lose all events emitted until we get a reconnection. This PR seeks to implement recovery logic to the running Relay.
Caveats
It's important to not that the current Relay implementation does not provide permanent state, so if for any reason the Relay itself goes down we currently don't provide a way to recover prior emitted events, the only events that are currently possible to recover are the ones a current running Relay identifies it didn't process due to websocket connection loss.
Related issues
Closes #743