Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release v0.17.0 #786

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Prepare for release v0.17.0 #786

merged 5 commits into from
Aug 11, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Aug 11, 2023 •
edited

The following crates require a newer version of rust, so these will be deferred until a later release:

  • bonsai-ethereum-contracts
  • bonsai-ethereum-relay
  • bonsai-rest-api-mock

@flaub flaub self-assigned this Aug 11, 2023
@flaub flaub requested a review from capossele August 11, 2023 10:13
@github-actions
Copy link

Benchmark for Linux-cuda 517f965

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.10ms 5.1±0.11ms 0.00%
fib/100/prove 772.2±5.33ms 761.8±3.96ms -1.35%
fib/100/total 769.7±5.80ms 759.3±3.46ms -1.35%
fib/1000/execute 5.5±0.12ms 5.5±0.10ms 0.00%
fib/1000/prove 796.5±3.44ms 786.8±3.18ms -1.22%
fib/1000/total 802.2±3.36ms 792.3±4.72ms -1.23%
fib/10000/execute 10.2±0.11ms 10.2±0.12ms 0.00%
fib/10000/prove 3.1±0.01s 3.0±0.00s -3.23%
fib/10000/total 3.2±0.01s 3.0±0.01s -6.25%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal 517f965

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.16ms 2.8±0.23ms 0.00%
fib/100/prove 854.5±3.12ms 846.9±4.63ms -0.89%
fib/100/total 875.6±8.49ms 871.1±13.02ms -0.51%
fib/1000/execute 2.9±0.05ms 2.9±0.13ms 0.00%
fib/1000/prove 872.2±5.24ms 869.6±3.31ms -0.30%
fib/1000/total 896.3±5.97ms 871.5±6.54ms -2.77%
fib/10000/execute 5.1±0.05ms 5.1±0.07ms 0.00%
fib/10000/prove 3.3±0.01s 3.3±0.02s 0.00%
fib/10000/total 3.3±0.01s 3.3±0.01s 0.00%

@capossele
Copy link
Contributor

Should we also include the crate bonsai-ethereum-contracts @nategraf ?

@flaub flaub requested review from tzerrell, pdg744 and 3lkn August 11, 2023 11:57
pdg744
pdg744 reviewed Aug 11, 2023
View reviewed changes
examples/bevy/README.md
zkVM applications are organized into a [host program] and a [guest program].
The host program can be found in [`src/main.rs`] and the guest program can be found in [`methods/guest/src/main.rs`].

The [host] first [executes] the guest program and then [proves the execution] to construct a [receipt].
The receipt can be passed to a third party, who can examine the [journal] to check the program's outputs and can [verify] the [receipt] to ensure the integrity of the [guest program]'s execution.

[`src/main.rs`]: https://github.com/risc0/risc0/tree/v0.16.1/examples/bevy/src/main.rs
[`methods/guest/src/main.rs`]: https://github.com/risc0/risc0/tree/v0.16.1/examples/bevy/methods/guest/src/main.rs
[`src/main.rs`]: src/main.rs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tzerrell and I have recently been expressing some uncertainty about whether the relative paths or full url paths are preferable in this context

@flaub flaub enabled auto-merge (squash) August 11, 2023 12:20
pdg744
pdg744 reviewed Aug 11, 2023
View reviewed changes
examples/wordle/README.md
@@ -2,7 +2,7 @@

## Quick Start

First, make sure [rustup](https://rustup.rs) is installed. This project uses a [nightly](https://doc.rust-lang.org/book/appendix-07-nightly-rust.html) version of [Rust](https://doc.rust-lang.org/book/ch01-01-installation.html). The [`rust-toolchain`](rust-toolchain) file will be used by `cargo` to automatically install the correct version.
First, make sure [rustup](https://rustup.rs) is installed. This project uses a [nightly](https://doc.rust-lang.org/book/appendix-07-nightly-rust.html) version of [Rust](https://doc.rust-lang.org/book/ch01-01-installation.html). The [`rust-toolchain.toml`](../../rust-toolchain.toml) file will be used by `cargo` to automatically install the correct version.
Copy link
Contributor

@pdg744 pdg744 Aug 11, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we align the recommendations here with the other examples?

Suggested change
First, make sure [rustup](https://rustup.rs) is installed. This project uses a [nightly](https://doc.rust-lang.org/book/appendix-07-nightly-rust.html) version of [Rust](https://doc.rust-lang.org/book/ch01-01-installation.html). The [`rust-toolchain.toml`](../../rust-toolchain.toml) file will be used by `cargo` to automatically install the correct version.
First, [install Rust] if you don't already have it.
Next, install the `cargo-risczero` tool and install the toolchain with:
```bash
cargo install risczero
cargo risczero install

Then, run the example with:

cargo run --release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. I've already published this PR so we'll need to do this in a follow-up PR

@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal ba97d6c

Click to hide benchmark
Test Base PR %
fib/100/execute 2.7±0.13ms 2.7±0.13ms 0.00%
fib/100/prove 853.8±6.87ms 853.7±4.85ms -0.01%
fib/100/total 878.7±4.39ms 875.9±8.01ms -0.32%
fib/1000/execute 2.9±0.08ms 2.9±0.06ms 0.00%
fib/1000/prove 872.2±4.06ms 870.9±2.92ms -0.15%
fib/1000/total 906.4±8.93ms 898.4±6.97ms -0.88%
fib/10000/execute 5.0±0.14ms 5.0±0.09ms 0.00%
fib/10000/prove 3.4±0.01s 3.3±0.01s -2.94%
fib/10000/total 3.4±0.01s 3.3±0.01s -2.94%

@flaub flaub merged commit da5bc39 into main Aug 11, 2023
19 checks passed
@flaub flaub deleted the flaub/bump branch August 11, 2023 13:21
@nategraf
Copy link
Contributor

Should we also include the crate bonsai-ethereum-contracts @nategraf ?

It's not necessary since Foundry uses submodules for dependency management. It does mean that the bonsai-foundry-template will use a git dependency for the relay instead of pulling from crates.io, but I think that's fine for now. Overall I think leaving it off crates.io for now seems like the right call. All we need right now is a git tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdg744 pdg744 pdg744 left review comments

@nategraf nategraf nategraf approved these changes

@capossele capossele capossele approved these changes

@mothran mothran Awaiting requested review from mothran

@SchmErik SchmErik Awaiting requested review from SchmErik

@carterbrett carterbrett Awaiting requested review from carterbrett

@tzerrell tzerrell Awaiting requested review from tzerrell

@3lkn 3lkn Awaiting requested review from 3lkn

Assignees

@flaub flaub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flaub @capossele @nategraf @pdg744