Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bootstraps over to xtask #791

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Move bootstraps over to xtask #791

merged 4 commits into from
Aug 15, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Aug 13, 2023

No description provided.

@flaub flaub self-assigned this Aug 13, 2023
@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 51b4a5b

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.09ms 2.8±0.19ms 0.00%
fib/100/prove 3.7±0.07s 3.7±0.05s 0.00%
fib/100/total 3.7±0.06s 3.7±0.06s 0.00%
fib/1000/execute 3.0±0.12ms 2.8±0.11ms -6.67%
fib/1000/prove 3.7±0.07s 3.6±0.07s -2.70%
fib/1000/total 3.7±0.05s 3.7±0.05s 0.00%
fib/10000/execute 5.1±0.14ms 5.1±0.07ms 0.00%
fib/10000/prove 15.3±0.09s 15.3±0.10s 0.00%
fib/10000/total 15.4±0.10s 15.3±0.14s -0.65%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

xtask/src/install.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@SchmErik SchmErik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good aside from the typo

@flaub flaub enabled auto-merge (squash) August 15, 2023 09:03
@flaub flaub merged commit f0438fb into main Aug 15, 2023
15 of 19 checks passed
@flaub flaub deleted the flaub/bootstrap branch August 15, 2023 09:53
@github-actions
Copy link

Benchmark for Linux-cuda d38e377

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.12ms 5.1±0.10ms 0.00%
fib/100/prove 889.5±9.45ms 808.6±1.83ms -9.09%
fib/100/total 827.9±10.36ms 813.5±2.09ms -1.74%
fib/1000/execute 5.6±0.09ms 5.5±0.11ms -1.79%
fib/1000/prove 890.1±17.24ms 830.9±2.02ms -6.65%
fib/1000/total 860.4±9.30ms 839.2±3.01ms -2.46%
fib/10000/execute 10.2±0.10ms 10.2±0.11ms 0.00%
fib/10000/prove 3.2±0.02s 2.7±0.00s -15.63%
fib/10000/total 3.2±0.01s 2.8±0.00s -12.50%

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default d38e377

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.16ms 2.7±0.06ms -3.57%
fib/100/prove 3.7±0.07s 3.7±0.06s 0.00%
fib/100/total 3.7±0.06s 3.7±0.06s 0.00%
fib/1000/execute 3.0±0.08ms 3.0±0.09ms 0.00%
fib/1000/prove 3.7±0.08s 3.7±0.06s 0.00%
fib/1000/total 3.7±0.07s 3.7±0.07s 0.00%
fib/10000/execute 5.2±0.05ms 5.2±0.07ms 0.00%
fib/10000/prove 15.3±0.10s 15.2±0.07s -0.65%
fib/10000/total 15.3±0.06s 15.3±0.12s 0.00%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants