Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crate-validator): Add domain-specific crates #792

Merged
merged 26 commits into from
Aug 31, 2023

Conversation

Cardosaum
Copy link
Contributor

@Cardosaum Cardosaum commented Aug 14, 2023

Overview

This PR seeks to address points raised in #562, and also adds other improvements on the existing tool:

  • Downloads no longer time out due to slow internet connection,
  • Progress bar for download process added.

Related issues

Closes #562

@Cardosaum Cardosaum self-assigned this Aug 14, 2023
@Cardosaum Cardosaum added the enhancement New feature or request label Aug 14, 2023
@Cardosaum Cardosaum marked this pull request as ready for review August 29, 2023 15:29
@Cardosaum Cardosaum requested a review from mothran August 29, 2023 15:30
@Cardosaum Cardosaum enabled auto-merge (squash) August 29, 2023 15:30
@mothran
Copy link
Contributor

mothran commented Aug 29, 2023

Nice work! Looks like a good bit of code cleanup as well. Just left a few small notes.

Copy link
Contributor

@mothran mothran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cardosaum Cardosaum merged commit c19fd33 into main Aug 31, 2023
17 checks passed
@Cardosaum Cardosaum deleted the cardosaum/crate-validator-aditional-crates branch August 31, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional list of "important crates" to inject into the top 1000 crates for validation
3 participants