Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a description of Step 2 #793

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

winor30
Copy link
Contributor

@winor30 winor30 commented Aug 14, 2023

Added a procedure to the description because it did not work properly without modifying host/Cargo.toml.

- Rename the package name in `methods/Cargo.toml` to match the name of the project
- Rename `host/Cargo.toml` to read guest code correctly
@pdg744 pdg744 mentioned this pull request Aug 14, 2023
3 tasks
@pdg744 pdg744 requested review from 3lkn and tzerrell August 23, 2023 15:53
@carterbrett carterbrett assigned carterbrett and pdg744 and unassigned carterbrett Aug 28, 2023
@pdg744 pdg744 removed their assignment Sep 5, 2023
@tzerrell tzerrell self-assigned this Sep 6, 2023
Copy link
Member

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

examples/factors/README.md Outdated Show resolved Hide resolved
examples/factors/README.md Outdated Show resolved Hide resolved
@tzerrell tzerrell enabled auto-merge (squash) September 12, 2023 16:50
@tzerrell tzerrell merged commit b5085e5 into risc0:main Sep 12, 2023
15 checks passed
tzerrell added a commit that referenced this pull request Sep 12, 2023
@winor30 winor30 deleted the chore/add-description-factors-examples branch September 12, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants