Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stable host toolchain #817

Merged
merged 5 commits into from
Aug 27, 2023
Merged

Support for stable host toolchain #817

merged 5 commits into from
Aug 27, 2023

Conversation

flaub
Copy link
Member

@flaub flaub commented Aug 26, 2023

  • Switch to stable channel in rust-toolchain.toml
  • Adjust risc0-build to support any host-side rustc version.
  • Download LLVM source for build-toolchain
  • risc0-build uses env vars to make debugging toolchains easier
  • Add --version to risczero install

* Download LLVM source for build-toolchain
* `risc0-build` uses env vars to make debugging toolchains easier
@flaub flaub requested review from mothran and SchmErik August 26, 2023 14:17
@github-actions
Copy link

Benchmark for Linux-cuda

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for Linux-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-default 43b2687

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.23ms 2.7±0.12ms -3.57%
fib/100/prove 3.7±0.08s 3.7±0.06s 0.00%
fib/100/total 3.7±0.07s 3.7±0.05s 0.00%
fib/1000/execute 3.0±0.17ms 2.9±0.10ms -3.33%
fib/1000/prove 3.7±0.06s 3.7±0.09s 0.00%
fib/1000/total 3.7±0.05s 3.7±0.06s 0.00%
fib/10000/execute 5.1±0.08ms 5.0±0.13ms -1.96%
fib/10000/prove 15.3±0.08s 15.2±0.10s -0.65%
fib/10000/total 15.3±0.18s 15.3±0.14s 0.00%

Benchmark for macOS-metal 43b2687

Click to hide benchmark
Test Base PR %
fib/100/execute 2.7±0.16ms 2.6±0.13ms -3.70%
fib/100/prove 857.5±4.82ms 856.6±5.48ms -0.10%
fib/100/total 879.3±6.66ms 877.4±6.28ms -0.22%
fib/1000/execute 3.0±0.07ms 3.0±0.06ms 0.00%
fib/1000/prove 873.6±2.53ms 871.5±7.54ms -0.24%
fib/1000/total 904.4±4.83ms 892.2±4.63ms -1.35%
fib/10000/execute 5.1±0.13ms 5.0±0.06ms -1.96%
fib/10000/prove 3.4±0.01s 3.3±0.01s -2.94%
fib/10000/total 3.4±0.01s 3.3±0.01s -2.94%

@flaub flaub changed the title Support for build-toolchain Support for stable host toolchain Aug 26, 2023
@flaub
Copy link
Member Author

flaub commented Aug 26, 2023

I think I stumbled on a possible fix for #815.

@github-actions
Copy link

Benchmark for Linux-cuda 457e876

Click to hide benchmark
Test Base PR %
fib/100/execute 5.0±0.11ms 5.0±0.10ms 0.00%
fib/100/prove 1458.8±1.26ms 733.6±1.02ms -49.71%
fib/100/total 1477.8±1.14ms 737.9±0.46ms -50.07%
fib/1000/execute 5.6±0.11ms 5.6±0.11ms 0.00%
fib/1000/prove 1482.5±0.99ms 762.9±0.83ms -48.54%
fib/1000/total 1498.3±1.10ms 768.5±0.67ms -48.71%
fib/10000/execute 11.5±0.13ms 10.2±0.11ms -11.30%
fib/10000/prove 6.2±0.03s 2.8±0.00s -54.84%
fib/10000/total 6.4±0.15s 2.8±0.00s -56.25%

Benchmark for Linux-default 457e876

Click to hide benchmark
Test Base PR %
fib/100/execute 4.8±0.21ms 4.8±0.19ms 0.00%
fib/100/prove 2.6±0.50s 2.4±0.40s -7.69%
fib/100/total 2.3±0.28s 2.1±0.22s -8.70%
fib/1000/execute 5.3±0.13ms 5.2±0.09ms -1.89%
fib/1000/prove 2.8±0.54s 1992.4±470.96ms -28.84%
fib/1000/total 2.7±0.55s 2.1±0.22s -22.22%
fib/10000/execute 10.0±0.08ms 9.0±0.10ms -10.00%
fib/10000/prove 8.4±1.51s 7.6±0.68s -9.52%
fib/10000/total 7.6±0.41s 7.4±0.51s -2.63%

Benchmark for macOS-default

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

Benchmark for macOS-metal 457e876

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.06ms 2.5±0.17ms -10.71%
fib/100/prove 854.3±5.23ms 847.8±5.51ms -0.76%
fib/100/total 878.8±4.37ms 876.6±3.67ms -0.25%
fib/1000/execute 2.9±0.03ms 2.8±0.16ms -3.45%
fib/1000/prove 872.4±4.13ms 865.8±4.01ms -0.76%
fib/1000/total 901.3±5.11ms 896.9±6.88ms -0.49%
fib/10000/execute 5.6±0.16ms 5.1±0.13ms -8.93%
fib/10000/prove 3.3±0.01s 3.3±0.01s 0.00%
fib/10000/total 3.3±0.01s 3.3±0.01s 0.00%

@flaub flaub enabled auto-merge (squash) August 26, 2023 15:46
@github-actions
Copy link

Benchmark for Linux-cuda bc31aed

Click to hide benchmark
Test Base PR %
fib/100/execute 5.2±0.12ms 5.0±0.12ms -3.85%
fib/100/prove 1584.8±26.20ms 831.8±1.71ms -47.51%
fib/100/total 1342.2±36.13ms 835.5±0.75ms -37.75%
fib/1000/execute 5.7±0.16ms 5.6±0.09ms -1.75%
fib/1000/prove 1537.4±52.81ms 860.3±0.75ms -44.04%
fib/1000/total 1356.4±5.99ms 864.3±0.43ms -36.28%
fib/10000/execute 11.5±0.14ms 10.2±0.18ms -11.30%
fib/10000/prove 5.4±0.04s 2.9±0.00s -46.30%
fib/10000/total 5.2±0.07s 2.9±0.00s -44.23%

Benchmark for Linux-default bc31aed

Click to hide benchmark
Test Base PR %
fib/100/execute 4.8±0.17ms 4.6±0.09ms -4.17%
fib/100/prove 2.8±0.91s 2.0±0.22s -28.57%
fib/100/total 2.8±0.68s 2.3±0.39s -17.86%
fib/1000/execute 5.4±0.23ms 5.3±0.14ms -1.85%
fib/1000/prove 10.6±8.80s 2.1±0.37s +-80.19%
fib/1000/total 2.6±0.28s 2.2±0.15s -15.38%
fib/10000/execute 10.1±0.28ms 9.1±0.19ms -9.90%
fib/10000/prove 8.4±2.19s 7.5±0.14s -10.71%
fib/10000/total 7.9±1.09s 7.8±1.55s -1.27%

Benchmark for macOS-default bc31aed

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.19ms 2.8±0.13ms 0.00%
fib/100/prove 3.7±0.05s 3.7±0.07s 0.00%
fib/100/total 3.7±0.09s 3.7±0.05s 0.00%
fib/1000/execute 3.0±0.05ms 2.9±0.05ms -3.33%
fib/1000/prove 3.7±0.06s 3.7±0.04s 0.00%
fib/1000/total 3.7±0.07s 3.7±0.07s 0.00%
fib/10000/execute 5.7±0.05ms 5.1±0.12ms -10.53%
fib/10000/prove 15.3±0.13s 15.2±0.18s -0.65%
fib/10000/total 15.3±0.16s 15.2±0.09s -0.65%

Benchmark for macOS-metal

    <details open>
      <summary>Click to hide benchmark</summary>
      Benchmarks have changed between the two branches, unable to diff.
    </details>

@github-actions
Copy link

Benchmark for Linux-cuda da038d2

Click to hide benchmark
Test Base PR %
fib/100/execute 5.0±0.10ms 5.0±0.11ms 0.00%
fib/100/prove 1684.3±58.41ms 737.2±2.36ms -56.23%
fib/100/total 1495.3±11.68ms 732.4±3.00ms -51.02%
fib/1000/execute 5.7±0.11ms 5.6±0.11ms -1.75%
fib/1000/prove 1612.2±7.64ms 765.6±2.40ms -52.51%
fib/1000/total 1554.3±8.54ms 761.9±1.78ms -50.98%
fib/10000/execute 11.5±0.12ms 10.2±0.11ms -11.30%
fib/10000/prove 5.2±0.02s 2.7±0.01s -48.08%
fib/10000/total 5.0±0.02s 2.7±0.00s -46.00%

Benchmark for Linux-default da038d2

Click to hide benchmark
Test Base PR %
fib/100/execute 4.8±0.20ms 4.7±0.14ms -2.08%
fib/100/prove 2.6±0.59s 2.1±0.33s -19.23%
fib/100/total 2.7±0.76s 2.6±0.46s -3.70%
fib/1000/execute 5.3±0.10ms 5.3±0.06ms 0.00%
fib/1000/prove 2.5±0.35s 2.3±0.20s -8.00%
fib/1000/total 2.7±0.59s 2.3±0.15s -14.81%
fib/10000/execute 10.0±0.17ms 9.1±0.15ms -9.00%
fib/10000/prove 7.5±0.36s 7.3±0.58s -2.67%
fib/10000/total 7.8±0.75s 7.4±0.34s -5.13%

Benchmark for macOS-default da038d2

Click to hide benchmark
Test Base PR %
fib/100/execute 2.7±0.16ms 2.7±0.10ms 0.00%
fib/100/prove 3.7±0.10s 3.6±0.08s -2.70%
fib/100/total 3.7±0.05s 3.6±0.06s -2.70%
fib/1000/execute 3.0±0.07ms 2.9±0.07ms -3.33%
fib/1000/prove 3.7±0.07s 3.7±0.05s 0.00%
fib/1000/total 3.7±0.04s 3.7±0.03s 0.00%
fib/10000/execute 5.7±0.03ms 5.1±0.10ms -10.53%
fib/10000/prove 15.3±0.18s 15.2±0.09s -0.65%
fib/10000/total 15.3±0.10s 15.2±0.11s -0.65%

Benchmark for macOS-metal da038d2

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.12ms 2.6±0.12ms -7.14%
fib/100/prove 848.5±3.54ms 848.1±2.48ms -0.05%
fib/100/total 877.7±4.25ms 874.2±4.09ms -0.40%
fib/1000/execute 3.0±0.07ms 2.9±0.06ms -3.33%
fib/1000/prove 869.4±6.71ms 866.5±4.21ms -0.33%
fib/1000/total 901.4±4.42ms 889.8±6.48ms -1.29%
fib/10000/execute 5.8±0.11ms 5.0±0.06ms -13.79%
fib/10000/prove 3.3±0.01s 3.3±0.01s 0.00%
fib/10000/total 3.3±0.01s 3.3±0.01s 0.00%

@github-actions
Copy link

Benchmark for Linux-cuda 60bec6a

Click to hide benchmark
Test Base PR %
fib/100/execute 5.1±0.10ms 5.0±0.11ms -1.96%
fib/100/prove 1907.7±17.54ms 733.2±2.71ms -61.57%
fib/100/total 1740.1±10.85ms 816.4±3.07ms -53.08%
fib/1000/execute 5.6±0.10ms 5.6±0.11ms 0.00%
fib/1000/prove 1892.2±13.35ms 842.5±2.37ms -55.48%
fib/1000/total 1779.5±20.86ms 849.6±2.02ms -52.26%
fib/10000/execute 11.4±0.13ms 10.2±0.11ms -10.53%
fib/10000/prove 5.5±0.03s 2.7±0.00s -50.91%
fib/10000/total 5.4±0.04s 2.8±0.00s -48.15%

Benchmark for Linux-default 60bec6a

Click to hide benchmark
Test Base PR %
fib/100/execute 4.8±0.20ms 4.6±0.13ms -4.17%
fib/100/prove 2.7±0.21s 1658.8±54.19ms -38.56%
fib/100/total 1874.0±371.26ms 1661.6±9.53ms -11.33%
fib/1000/execute 5.2±0.08ms 5.2±0.11ms 0.00%
fib/1000/prove 2.3±0.27s 1692.4±65.41ms -26.42%
fib/1000/total 1709.1±7.58ms 1690.6±8.84ms -1.08%
fib/10000/execute 9.9±0.18ms 8.9±0.10ms -10.10%
fib/10000/prove 7.7±0.50s 6.4±0.15s -16.88%
fib/10000/total 6.5±0.15s 6.4±0.16s -1.54%

Benchmark for macOS-default 60bec6a

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.13ms 2.6±0.04ms -7.14%
fib/100/prove 3.7±0.07s 3.7±0.10s 0.00%
fib/100/total 3.7±0.03s 3.7±0.05s 0.00%
fib/1000/execute 3.0±0.11ms 2.9±0.05ms -3.33%
fib/1000/prove 3.7±0.04s 3.7±0.04s 0.00%
fib/1000/total 3.7±0.07s 3.7±0.05s 0.00%
fib/10000/execute 5.7±0.12ms 5.1±0.08ms -10.53%
fib/10000/prove 15.3±0.15s 15.2±0.15s -0.65%
fib/10000/total 15.2±0.10s 15.2±0.10s 0.00%

Benchmark for macOS-metal 60bec6a

Click to hide benchmark
Test Base PR %
fib/100/execute 2.8±0.05ms 2.8±0.07ms 0.00%
fib/100/prove 849.6±3.98ms 847.1±3.35ms -0.29%
fib/100/total 877.4±6.42ms 869.3±6.45ms -0.92%
fib/1000/execute 3.0±0.05ms 2.9±0.07ms -3.33%
fib/1000/prove 870.3±5.62ms 862.4±3.10ms -0.91%
fib/1000/total 898.4±8.23ms 890.7±7.25ms -0.86%
fib/10000/execute 5.8±0.10ms 5.0±0.06ms -13.79%
fib/10000/prove 3.4±0.01s 3.3±0.01s -2.94%
fib/10000/total 3.4±0.01s 3.3±0.01s -2.94%

@flaub flaub merged commit b498f9a into main Aug 27, 2023
20 checks passed
@flaub flaub deleted the flaub/bump-rust branch August 27, 2023 02:47
@flaub flaub self-assigned this Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants