Bonsai: Migrate SnarkProof types to match backend #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated to the SnarkProof + SnarkSeal model from bonsai inline with the backend changes
tzerrell
approved these changes
Sep 12, 2023
nategraf
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
I like this simplification!
bonsai/ethereum-relay/src/uploader/completed_proofs/complete_proof.rs
Outdated
Show resolved
Hide resolved
nategraf
approved these changes
Sep 12, 2023
|
Update: bonsai-foundry-template ( with some update: risc0/risc0-foundry-template#58) works e2e on my end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated to the more complete SnarkProof type from Bonsai to enable easier ETH verify integrations.
I updated most of the relay codebase to match the the new format, I hope I got everything wired up correctly but if someone who knows how to drive e2e testing with bonsai could help me validate it that would be great!.